From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RDNS_NONE,SPF_HELO_NONE,SPF_NONE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from metis.ext.pengutronix.de ([85.220.165.71]:43073 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730316AbgCKQov (ORCPT ); Wed, 11 Mar 2020 12:44:51 -0400 Date: Wed, 11 Mar 2020 17:44:49 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Rishi Gupta Cc: thierry.reding@gmail.com, s.trumtrar@pengutronix.de, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] pwm: pca9685: replace CONFIG_PM with __maybe_unused to prevent build issues Message-ID: <20200311164449.flzzwxqqhcxisil3@pengutronix.de> References: <1583941429-10921-1-git-send-email-gupt21@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1583941429-10921-1-git-send-email-gupt21@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Mar 11, 2020 at 09:13:49PM +0530, Rishi Gupta wrote: > The __maybe_unused attribute is preferred over CONFIG_PM > to prevent build time issues. This commit replaces CONFIG_PM > with this attribute. I wasn't aware of build time issues and thought this was just about #ifdef being ugly. Anyhow, the change is fine, Acked-by: Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |