From: Daniel Thompson <daniel.thompson@linaro.org>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <mripard@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
Stephan Gerhold <stephan@gerhold.net>,
Mark Brown <broonie@kernel.org>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] dt-bindings: power: supply: add cw2015_battery bindings
Date: Wed, 11 Mar 2020 17:20:56 +0000 [thread overview]
Message-ID: <20200311172056.wjn3574zrfqxipw6@holly.lan> (raw)
In-Reply-To: <20200311093043.3636807-3-t.schramm@manjaro.org>
On Wed, Mar 11, 2020 at 10:30:42AM +0100, Tobias Schramm wrote:
> This patch adds the dts binding schema for the cw2015 fuel gauge.
>
> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> ---
> .../bindings/power/supply/cw2015_battery.yaml | 83 +++++++++++++++++++
> 1 file changed, 83 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml b/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml
> new file mode 100644
> index 000000000000..647dbc6e136e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/cw2015_battery.yaml
> @@ -0,0 +1,83 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/cw2015_battery.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Battery driver for CW2015 shuntless fule gauge by CellWise.
s/fule/fuel/
> +
> +maintainers:
> + - Tobias Schramm <t.schramm@manjaro.org>
> +
> +description: |
> + The driver can utilize information from a simple-battery linked via a
> + phandle in monitored-battery. If specified the driver uses the
> + charge-full-design-microamp-hours property of the battery.
> +
> +properties:
> + compatible:
> + const: cellwise,cw2015
> +
> + reg:
> + items:
> + - description: i2c address
> +
> + cellwise,battery-profile:
> + description: |
> + This property specifies characteristics of the battery used. The format
> + of this binary blob is kept secret by CellWise. The only way to obtain
> + it is to mail two batteries to a test facility of CellWise and receive
> + back a test report with the binary blob.
> + allOf:
> + - $ref: /schemas/types.yaml#definitions/uint8-array
> + items:
> + - minItems: 64
> + maxItems: 64
> +
> + cellwise,monitor-interval-ms:
> + description:
> + Specifies the interval in milliseconds gauge values are polled at
> + $ref: /schemas/types.yaml#/definitions/uint32
> +
> + power-supplies:
> + description:
> + Specifies supplies used for charging the battery connected to this gauge
> + allOf:
> + - $ref: /schemas/types.yaml#/definitions/phandle-array
> + - minItems: 1
> + maxItems: 8 # Should be enough
Is it necessary to set a maximum? power_supply.txt is still a text file
but there is no mention of a maximum there.
Daniel.
next prev parent reply other threads:[~2020-03-11 17:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 9:30 [PATCH v3 0/3] Add support for CellWise cw2015 fuel gauge Tobias Schramm
2020-03-11 9:30 ` [PATCH v3 1/3] dt-bindings: Document cellwise vendor-prefix Tobias Schramm
2020-03-11 9:30 ` [PATCH v3 2/3] dt-bindings: power: supply: add cw2015_battery bindings Tobias Schramm
2020-03-11 17:20 ` Daniel Thompson [this message]
2020-03-11 23:17 ` Tobias Schramm
2020-03-12 10:17 ` Daniel Thompson
2020-03-11 9:30 ` [PATCH v3 3/3] power: supply: add CellWise cw2015 fuel gauge driver Tobias Schramm
2020-03-11 10:18 ` Andy Shevchenko
2020-03-11 10:22 ` Andy Shevchenko
2020-03-11 23:51 ` Tobias Schramm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200311172056.wjn3574zrfqxipw6@holly.lan \
--to=daniel.thompson@linaro.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sre@kernel.org \
--cc=stephan@gerhold.net \
--cc=t.schramm@manjaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).