From: Ashish Kalra <ashish.kalra@amd.com>
To: Steve Rutherford <srutherford@google.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>, "Borislav Petkov" <bp@suse.de>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"David Rientjes" <rientjes@google.com>, "X86 ML" <x86@kernel.org>,
"KVM list" <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
brijesh.singh@amd.com
Subject: Re: [PATCH 04/12] KVM: SVM: Add support for KVM_SEV_RECEIVE_START command
Date: Thu, 12 Mar 2020 00:38:55 +0000 [thread overview]
Message-ID: <20200312003855.GA26448@ashkalra_ubuntu_server> (raw)
In-Reply-To: <CABayD+ciJiF8gf+s6d57vENcnSQPQGzTTwdo0TLBsNLdoy0tWw@mail.gmail.com>
On Mon, Mar 09, 2020 at 06:41:02PM -0700, Steve Rutherford wrote:
> > +static int sev_receive_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
> > +{
> > + struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;
> > + struct sev_data_receive_start *start;
> > + struct kvm_sev_receive_start params;
> > + int *error = &argp->error;
> > + void *session_data;
> > + void *pdh_data;
> > + int ret;
> > +
> > + if (!sev_guest(kvm))
> > + return -ENOTTY;
> > +
> > + /* Get parameter from the userspace */
> > + if (copy_from_user(¶ms, (void __user *)(uintptr_t)argp->data,
> > + sizeof(struct kvm_sev_receive_start)))
> > + return -EFAULT;
> > +
> > + /* some sanity checks */
> > + if (!params.pdh_uaddr || !params.pdh_len ||
> > + !params.session_uaddr || !params.session_len)
> > + return -EINVAL;
> > +
> > + pdh_data = psp_copy_user_blob(params.pdh_uaddr, params.pdh_len);
> > + if (IS_ERR(pdh_data))
> > + return PTR_ERR(pdh_data);
> > +
> > + session_data = psp_copy_user_blob(params.session_uaddr,
> > + params.session_len);
> > + if (IS_ERR(session_data)) {
> > + ret = PTR_ERR(session_data);
> > + goto e_free_pdh;
> > + }
> > +
> > + ret = -ENOMEM;
> > + start = kzalloc(sizeof(*start), GFP_KERNEL);
> > + if (!start)
> > + goto e_free_session;
> > +
> > + start->handle = params.handle;
> > + start->policy = params.policy;
> > + start->pdh_cert_address = __psp_pa(pdh_data);
> > + start->pdh_cert_len = params.pdh_len;
> > + start->session_address = __psp_pa(session_data);
> > + start->session_len = params.session_len;
> > +
> > + /* create memory encryption context */
>
> Set ret to a different value here, since otherwise this will look like -ENOMEM.
But, ret will be the value returned by __sev_issue_cmd(), so why will it
look like -ENOMEM ?
>
> > + ret = __sev_issue_cmd(argp->sev_fd, SEV_CMD_RECEIVE_START, start,
> > + error);
> > + if (ret)
> > + goto e_free;
> > +
> > + /* Bind ASID to this guest */
>
> Ideally, set ret to another distinct value, since the error spaces for
> these commands overlap, so you won't be sure which had the problem.
> You also wouldn't be sure if one succeeded and the other failed vs
> both failing.
Both commands "may" return the same error code as set by sev_do_cmd(), but
then we need that very specific error code, sev_do_cmd() can't return
different error codes for each command it is issuing ?
>
> > + ret = sev_bind_asid(kvm, start->handle, error);
> > + if (ret)
> > + goto e_free;
> > +
Thanks,
Ashish
next prev parent reply other threads:[~2020-03-12 0:39 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 1:14 [PATCH 00/12] SEV Live Migration Patchset Ashish Kalra
2020-02-13 1:14 ` [PATCH 01/12] KVM: SVM: Add KVM_SEV SEND_START command Ashish Kalra
2020-03-09 21:28 ` Steve Rutherford
2020-03-10 0:19 ` Steve Rutherford
2020-02-13 1:15 ` [PATCH 02/12] KVM: SVM: Add KVM_SEND_UPDATE_DATA command Ashish Kalra
2020-03-10 1:04 ` Steve Rutherford
2020-03-12 1:49 ` Ashish Kalra
2020-02-13 1:16 ` [PATCH 03/12] KVM: SVM: Add KVM_SEV_SEND_FINISH command Ashish Kalra
2020-03-10 1:09 ` Steve Rutherford
2020-02-13 1:16 ` [PATCH 04/12] KVM: SVM: Add support for KVM_SEV_RECEIVE_START command Ashish Kalra
2020-03-10 1:41 ` Steve Rutherford
2020-03-12 0:38 ` Ashish Kalra [this message]
2020-03-12 2:55 ` Steve Rutherford
2020-02-13 1:16 ` [PATCH 05/12] KVM: SVM: Add KVM_SEV_RECEIVE_UPDATE_DATA command Ashish Kalra
2020-02-13 1:16 ` [PATCH 06/12] KVM: SVM: Add KVM_SEV_RECEIVE_FINISH command Ashish Kalra
2020-02-13 1:17 ` [PATCH 07/12] KVM: x86: Add AMD SEV specific Hypercall3 Ashish Kalra
2020-02-13 1:17 ` [PATCH 08/12] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall Ashish Kalra
2020-02-20 2:39 ` Steve Rutherford
2020-02-20 5:28 ` Ashish Kalra
2020-02-20 21:21 ` Ashish Kalra
2020-02-13 1:17 ` [PATCH 09/12] KVM: x86: Introduce KVM_GET_PAGE_ENC_BITMAP ioctl Ashish Kalra
2020-02-27 17:57 ` Venu Busireddy
2020-02-27 18:18 ` Venu Busireddy
2020-02-27 19:38 ` Ashish Kalra
2020-02-13 1:18 ` [PATCH 10/12] mm: x86: Invoke hypercall when page encryption status is changed Ashish Kalra
2020-02-13 5:42 ` Andy Lutomirski
2020-02-13 22:28 ` Ashish Kalra
2020-02-14 18:56 ` Andy Lutomirski
2020-02-14 20:36 ` Ashish Kalra
2020-02-20 1:58 ` Steve Rutherford
2020-02-20 2:12 ` Andy Lutomirski
2020-02-20 3:29 ` Steve Rutherford
2020-02-20 15:54 ` Brijesh Singh
2020-02-20 20:43 ` Steve Rutherford
2020-02-20 22:43 ` Brijesh Singh
2020-02-20 23:23 ` Steve Rutherford
2020-02-20 23:40 ` Andy Lutomirski
2020-02-13 1:18 ` [PATCH 11/12] KVM: x86: Introduce KVM_SET_PAGE_ENC_BITMAP ioctl Ashish Kalra
2020-02-13 1:18 ` [PATCH 12/12] KVM: x86: Introduce KVM_PAGE_ENC_BITMAP_RESET ioctl Ashish Kalra
2020-02-13 5:43 ` [PATCH 00/12] SEV Live Migration Patchset Andy Lutomirski
2020-02-13 23:09 ` Ashish Kalra
2020-02-14 18:58 ` Andy Lutomirski
2020-02-17 19:49 ` Ashish Kalra
2020-03-03 1:05 ` Steve Rutherford
2020-03-03 4:42 ` Ashish Kalra
2020-03-19 13:05 ` Paolo Bonzini
2020-03-19 16:18 ` Ashish Kalra
2020-03-19 16:24 ` Paolo Bonzini
2020-02-14 2:10 ` Brijesh Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312003855.GA26448@ashkalra_ubuntu_server \
--to=ashish.kalra@amd.com \
--cc=bp@suse.de \
--cc=brijesh.singh@amd.com \
--cc=hpa@zytor.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=srutherford@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).