From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 477B1C2BB1D for ; Thu, 12 Mar 2020 09:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2773720716 for ; Thu, 12 Mar 2020 09:19:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726713AbgCLJTu (ORCPT ); Thu, 12 Mar 2020 05:19:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:49584 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726567AbgCLJTt (ORCPT ); Thu, 12 Mar 2020 05:19:49 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6B79AAC67; Thu, 12 Mar 2020 09:19:47 +0000 (UTC) Received: by unicorn.suse.cz (Postfix, from userid 1000) id 94220E0C79; Thu, 12 Mar 2020 10:19:43 +0100 (CET) Date: Thu, 12 Mar 2020 10:19:43 +0100 From: Michal Kubecek To: netdev@vger.kernel.org Cc: Jakub Kicinski , David Miller , Jiri Pirko , Andrew Lunn , Florian Fainelli , John Linville , Johannes Berg , linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 03/15] ethtool: provide netdev features with FEATURES_GET request Message-ID: <20200312091943.GK8012@unicorn.suse.cz> References: <20200311154908.7fd7047d@kicinski-fedora-PC1C0HJN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311154908.7fd7047d@kicinski-fedora-PC1C0HJN> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2020 at 03:49:08PM -0700, Jakub Kicinski wrote: > On Wed, 11 Mar 2020 22:40:18 +0100 (CET) Michal Kubecek wrote: > > > > +#define ETHTOOL_DEV_FEATURE_WORDS ((NETDEV_FEATURE_COUNT + 31) / 32) > > nit: since this line is touched perhaps worth converting to > DIV_ROUND_UP()? Yes. > > + for (i = 0; i < ETHTOOL_DEV_FEATURE_WORDS; i++) > > + dest[i] = (u32)(src >> (32 * i)); > > nit: cast unnecessary OK. > > + all_features = ~(netdev_features_t)0 >> > > + (8 * sizeof(all_features) - NETDEV_FEATURE_COUNT); > > nit: GENMASK_ULL(NETDEV_FEATURE_COUNT % 32 - 1, 0) ? Nice, I wasn't aware of this macro. But unless I want to fill data->all directly, it would be without the "% 32" part. > > +static int features_fill_reply(struct sk_buff *skb, > > + const struct ethnl_req_info *req_base, > > + const struct ethnl_reply_data *reply_base) > > +{ > > + const struct features_reply_data *data = FEATURES_REPDATA(reply_base); > > + bool compact = req_base->flags & ETHTOOL_FLAG_COMPACT_BITSETS; > > + int ret; > > + > > + ret = ethnl_put_bitset32(skb, ETHTOOL_A_FEATURES_HW, data->hw, > > + data->all, NETDEV_FEATURE_COUNT, > > + netdev_features_strings, compact); > > + if (ret < 0) > > + return ret; > > + ret = ethnl_put_bitset32(skb, ETHTOOL_A_FEATURES_WANTED, data->wanted, > > + NULL, NETDEV_FEATURE_COUNT, > > + netdev_features_strings, compact); > > + if (ret < 0) > > + return ret; > > + ret = ethnl_put_bitset32(skb, ETHTOOL_A_FEATURES_ACTIVE, data->active, > > + NULL, NETDEV_FEATURE_COUNT, > > + netdev_features_strings, compact); > > + if (ret < 0) > > + return ret; > > + ret = ethnl_put_bitset32(skb, ETHTOOL_A_FEATURES_NOCHANGE, > > + data->nochange, NULL, NETDEV_FEATURE_COUNT, > > + netdev_features_strings, compact); > > + > > + return ret; > > nit: return directly? Ah, right. I eliminated "if (ret < 0)" but did not check again. Michal