From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: Syed Nayyar Waris <syednwaris@gmail.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] counter: 104-quad-8: Add lock guards for filter clock prescaler
Date: Thu, 12 Mar 2020 11:40:12 -0400 [thread overview]
Message-ID: <20200312154012.GC3250@icarus> (raw)
In-Reply-To: <20200312112552.GA32509@syed>
[-- Attachment #1: Type: text/plain, Size: 1913 bytes --]
On Thu, Mar 12, 2020 at 04:55:52PM +0530, Syed Nayyar Waris wrote:
> Add lock protection from race conditions in the 104-quad-8 counter
> driver for filter clock prescaler related changes. There is no IRQ
> handling so used spin_lock calls for protection.
>
> Fixes: 9b74dddf79be ("counter: 104-quad-8: Support Filter Clock
> Prescaler")
>
> Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
>
> Split the patch from generic interface and differential encoder cable
> status changes. Also, include more code statements for protection using
> spin_lock calls and remove protection from few code statements which are
> unnecessary.
> ---
Hello Syed,
Remove the review comments from the commit message and I think this
patch is all right. You can also extend the Fixes line so that it
doesn't wrap around. Add the following Signed-off-by line underneath
yours and it'll remind me that I've already reviewed this patch when you
submit v4 of your patchset:
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
Thank you,
William Breathitt Gray
> drivers/counter/104-quad-8.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
> index 9dab190..58615e4 100644
> --- a/drivers/counter/104-quad-8.c
> +++ b/drivers/counter/104-quad-8.c
> @@ -1230,6 +1230,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
> if (ret)
> return ret;
>
> + spin_lock(&priv->lock);
> +
> priv->fck_prescaler[channel_id] = prescaler;
>
> /* Reset Byte Pointer */
> @@ -1240,6 +1242,8 @@ static ssize_t quad8_signal_fck_prescaler_write(struct counter_device *counter,
> outb(QUAD8_CTR_RLD | QUAD8_RLD_RESET_BP | QUAD8_RLD_PRESET_PSC,
> base_offset + 1);
>
> + spin_unlock(&priv->lock);
> +
> return len;
> }
>
> --
> 2.7.4
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-03-12 15:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 11:25 [PATCH v3 3/3] counter: 104-quad-8: Add lock guards for filter clock prescaler Syed Nayyar Waris
2020-03-12 15:40 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312154012.GC3250@icarus \
--to=vilhelm.gray@gmail.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syednwaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).