From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0370FC1975A for ; Thu, 12 Mar 2020 19:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D3088206EB for ; Thu, 12 Mar 2020 19:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584039957; bh=z20ha9/TtTEVF5uZYR/NbzTMoeX/71wph3pFAZhYFyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2IC1EquTo2Pj7O2az7c0Da1Q25hKNn2HOgJAm/wy/+Zb1cqPTZSY8HzArmi0rtYnH JySjTQdhwdPr+1RtafgmUUS4KBUWf4Yim4P94XOL6t51mSSEZhOhuvJaYspHfsUwhv V9o5xoeLrDXKwU9J17GUFscCc0p5ZFt9VsuWa8Vg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726682AbgCLTF4 (ORCPT ); Thu, 12 Mar 2020 15:05:56 -0400 Received: from mail-ot1-f67.google.com ([209.85.210.67]:44602 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgCLTF4 (ORCPT ); Thu, 12 Mar 2020 15:05:56 -0400 Received: by mail-ot1-f67.google.com with SMTP id a49so4697207otc.11; Thu, 12 Mar 2020 12:05:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=MobSju737te+JzYsenr0FH2yt0dGhamzIqGShRXIww0=; b=AN8NcpbEBvo+d2HsEpIGadGY7HPChwo/Fgm7g1iD/ijc50XOUuPQq2SbJEriRWqxfJ NjzgXPr86FEGMv76wqLsFsTt1cKBeTr3q2Lkdy/+9CKW9THNZKqy6Q+is7OpBH6emkEL /WGJ3xn3rZo5mWB6ICQgq9tdNx84RxomDKRoYzQZmPzYoS0gdBJ2qFTmJ9YUaE1Rw3Ot JCfaBwaPTOU7B0tHZwep3PEWUkIB1iDx0Ei0R/8eOElD2pbd1KAoa6JOPBW/CrqFSv2/ 9s95gzPUh5/fqGs2AWvFDZljkN6EePI9ldjTQBCra1xkjie5JKdXW+jJlWprD/bXP0id cWhg== X-Gm-Message-State: ANhLgQ18QjUlnz8wreTwNgVKio9O7rGgnZwAuZwvlyLcS9+sCrQSujyi SLCziJUYimgzju8O7KhNUg== X-Google-Smtp-Source: ADFU+vtq2J5SulXMF97WnPUs+sTCKOEXlKI1n5cCcASwRTD3mYvpkHVbjij/yfwU4dUaGCxhLoVyiQ== X-Received: by 2002:a9d:19c8:: with SMTP id k66mr7205481otk.43.1584039954027; Thu, 12 Mar 2020 12:05:54 -0700 (PDT) Received: from rob-hp-laptop (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id t21sm15631904otk.13.2020.03.12.12.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 12:05:53 -0700 (PDT) Received: (nullmailer pid 31500 invoked by uid 1000); Thu, 12 Mar 2020 19:05:52 -0000 Date: Thu, 12 Mar 2020 14:05:52 -0500 From: Rob Herring To: Eason Yen Cc: Matthias Brugger , Mark Brown , jiaxin.yu@mediatek.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, wsd_upstream@mediatek.com Subject: Re: [PATCH 1/2] ASoC: mediatek: mt6359: add codec document Message-ID: <20200312190552.GA27630@bogus> References: <1583465622-16628-1-git-send-email-eason.yen@mediatek.com> <1583465622-16628-2-git-send-email-eason.yen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1583465622-16628-2-git-send-email-eason.yen@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 06, 2020 at 11:33:41AM +0800, Eason Yen wrote: > Add mt6359 codec document > > Signed-off-by: Eason Yen > --- > Documentation/devicetree/bindings/sound/mt6359.txt | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mt6359.txt Please convert to a DT schema. > > diff --git a/Documentation/devicetree/bindings/sound/mt6359.txt b/Documentation/devicetree/bindings/sound/mt6359.txt > new file mode 100644 > index 0000000..77864e0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mt6359.txt > @@ -0,0 +1,16 @@ > +Mediatek MT6359 Audio Codec > + > +The communication between MT6358 and SoC is through Mediatek PMIC wrapper. > +For more detail, please visit Mediatek PMIC wrapper documentation. > + > +Must be a child node of PMIC wrapper. > + > +Required properties: > + > +- compatible : "mediatek,mt6359-sound". A compatible with no other properties is generally suspect. Don't you have clocks, connection to I2S or something, etc. > + > +Example: > + > +mt6359_snd { audio-codec { > + compatible = "mediatek,mt6359-sound"; > +}; > -- > 1.9.1