From: Greg KH <gregkh@linuxfoundation.org>
To: Bruno Meneguele <bmeneg@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
pmladek@suse.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org
Subject: Re: [PATCH] kernel/printk: add kmsg SEEK_CUR handling
Date: Fri, 13 Mar 2020 08:22:54 +0100 [thread overview]
Message-ID: <20200313072254.GA1960396@kroah.com> (raw)
In-Reply-To: <20200313003533.2203429-1-bmeneg@redhat.com>
On Thu, Mar 12, 2020 at 09:35:33PM -0300, Bruno Meneguele wrote:
> Userspace libraries, e.g. glibc's dprintf(), expect the default return value
> for invalid seek situations: -ESPIPE, but when the IO was over /dev/kmsg the
> current state of kernel code was returning the generic case of an -EINVAL.
> Hence, userspace programs were not behaving as expected or documented.
>
> With this patch we add SEEK_CUR case returning the expected value and also a
> simple mention of it in kernel's documentation for those relying on that for
> guidance.
>
> Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
> ---
> Documentation/ABI/testing/dev-kmsg | 2 ++
> kernel/printk/printk.c | 4 ++++
> 2 files changed, 6 insertions(+)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2020-03-13 7:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 0:35 [PATCH] kernel/printk: add kmsg SEEK_CUR handling Bruno Meneguele
2020-03-13 7:22 ` Greg KH [this message]
2020-03-13 10:44 ` Bruno Meneguele
2020-03-13 7:34 ` Sergey Senozhatsky
2020-03-13 11:02 ` Bruno Meneguele
2020-03-13 11:06 ` David Laight
2020-03-13 13:06 ` Bruno Meneguele
2020-03-17 2:03 ` Sergey Senozhatsky
2020-03-17 8:53 ` Bruno Meneguele
2020-03-19 10:33 ` Bruno Meneguele
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313072254.GA1960396@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bmeneg@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).