linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/2] properly define some of PHYs
@ 2020-03-13 10:25 Oleksij Rempel
  2020-03-13 10:25 ` [PATCH v3 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 10:25 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
	Rob Herring, Sascha Hauer, Shawn Guo
  Cc: Oleksij Rempel, David S. Miller, devicetree, Fabio Estevam,
	Liam Girdwood, linux-arm-kernel, linux-kernel, Mark Brown,
	netdev, NXP Linux Team, Pengutronix Kernel Team, Russell King

changes v3:
- add phy-handle on the marsboard

changes v2:
- remove spaces

Oleksij Rempel (2):
  ARM: dts: imx6dl-riotboard: properly define rgmii PHY
  ARM: dts: imx6q-marsboard: properly define rgmii PHY

 arch/arm/boot/dts/imx6dl-riotboard.dts | 16 +++++++++++++++-
 arch/arm/boot/dts/imx6q-marsboard.dts  | 16 +++++++++++++++-
 2 files changed, 30 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v3 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY
  2020-03-13 10:25 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
@ 2020-03-13 10:25 ` Oleksij Rempel
  2020-03-13 10:25 ` [PATCH v3 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
  2020-03-16  2:47 ` [PATCH v2 0/2] properly define some of PHYs Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 10:25 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
	Rob Herring, Sascha Hauer, Shawn Guo
  Cc: Oleksij Rempel, David S. Miller, devicetree, Fabio Estevam,
	Liam Girdwood, linux-arm-kernel, linux-kernel, Mark Brown,
	netdev, NXP Linux Team, Pengutronix Kernel Team, Russell King

The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/imx6dl-riotboard.dts | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6dl-riotboard.dts b/arch/arm/boot/dts/imx6dl-riotboard.dts
index 829654e1835a..065d3ab0f50a 100644
--- a/arch/arm/boot/dts/imx6dl-riotboard.dts
+++ b/arch/arm/boot/dts/imx6dl-riotboard.dts
@@ -89,11 +89,25 @@ &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
-	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+	phy-handle = <&rgmii_phy>;
 	interrupts-extended = <&gpio1 6 IRQ_TYPE_LEVEL_HIGH>,
 			      <&intc 0 119 IRQ_TYPE_LEVEL_HIGH>;
 	fsl,err006687-workaround-present;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		/* Atheros AR8035 PHY */
+		rgmii_phy: ethernet-phy@4 {
+			reg = <4>;
+			interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+			reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
+			reset-deassert-us = <1000>;
+		};
+	};
 };
 
 &gpio1 {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH v3 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY
  2020-03-13 10:25 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
  2020-03-13 10:25 ` [PATCH v3 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
@ 2020-03-13 10:25 ` Oleksij Rempel
  2020-03-13 17:50   ` Andrew Lunn
  2020-03-16  2:47 ` [PATCH v2 0/2] properly define some of PHYs Shawn Guo
  2 siblings, 1 reply; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13 10:25 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
	Rob Herring, Sascha Hauer, Shawn Guo
  Cc: Oleksij Rempel, David S. Miller, devicetree, Fabio Estevam,
	Liam Girdwood, linux-arm-kernel, linux-kernel, Mark Brown,
	netdev, NXP Linux Team, Pengutronix Kernel Team, Russell King

The Atheros AR8035 PHY can be autodetected but can't use interrupt
support provided on this board. Define MDIO bus and the PHY node to make
it work properly.

Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
 arch/arm/boot/dts/imx6q-marsboard.dts | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts
index 84b30bd6908f..05ee28388229 100644
--- a/arch/arm/boot/dts/imx6q-marsboard.dts
+++ b/arch/arm/boot/dts/imx6q-marsboard.dts
@@ -111,8 +111,22 @@ &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
-	phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+	phy-handle = <&rgmii_phy>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		/* Atheros AR8035 PHY */
+		rgmii_phy: ethernet-phy@4 {
+			reg = <4>;
+			interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>;
+			reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
+			reset-deassert-us = <1000>;
+		};
+	};
 };
 
 &hdmi {
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3 2/2] ARM: dts: imx6q-marsboard: properly define rgmii PHY
  2020-03-13 10:25 ` [PATCH v3 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
@ 2020-03-13 17:50   ` Andrew Lunn
  0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2020-03-13 17:50 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Florian Fainelli, Heiner Kallweit, Mark Rutland, Rob Herring,
	Sascha Hauer, Shawn Guo, David S. Miller, devicetree,
	Fabio Estevam, Liam Girdwood, linux-arm-kernel, linux-kernel,
	Mark Brown, netdev, NXP Linux Team, Pengutronix Kernel Team,
	Russell King

On Fri, Mar 13, 2020 at 11:25:34AM +0100, Oleksij Rempel wrote:
> The Atheros AR8035 PHY can be autodetected but can't use interrupt
> support provided on this board. Define MDIO bus and the PHY node to make
> it work properly.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v2 0/2] properly define some of PHYs
  2020-03-13 10:25 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
  2020-03-13 10:25 ` [PATCH v3 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
  2020-03-13 10:25 ` [PATCH v3 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
@ 2020-03-16  2:47 ` Shawn Guo
  2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-03-16  2:47 UTC (permalink / raw)
  To: Oleksij Rempel
  Cc: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
	Rob Herring, Sascha Hauer, David S. Miller, devicetree,
	Fabio Estevam, Liam Girdwood, linux-arm-kernel, linux-kernel,
	Mark Brown, netdev, NXP Linux Team, Pengutronix Kernel Team,
	Russell King

On Fri, Mar 13, 2020 at 11:25:32AM +0100, Oleksij Rempel wrote:
> changes v3:
> - add phy-handle on the marsboard
> 
> changes v2:
> - remove spaces
> 
> Oleksij Rempel (2):
>   ARM: dts: imx6dl-riotboard: properly define rgmii PHY
>   ARM: dts: imx6q-marsboard: properly define rgmii PHY

Applied both, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH v2 0/2] properly define some of PHYs
@ 2020-03-13  5:32 Oleksij Rempel
  0 siblings, 0 replies; 6+ messages in thread
From: Oleksij Rempel @ 2020-03-13  5:32 UTC (permalink / raw)
  To: Andrew Lunn, Florian Fainelli, Heiner Kallweit, Mark Rutland,
	Rob Herring, Sascha Hauer, Shawn Guo
  Cc: Oleksij Rempel, David S. Miller, devicetree, Fabio Estevam,
	Liam Girdwood, linux-arm-kernel, linux-kernel, Mark Brown,
	netdev, NXP Linux Team, Pengutronix Kernel Team, Russell King

changes v2:
- remove spaces

Oleksij Rempel (2):
  ARM: dts: imx6dl-riotboard: properly define rgmii PHY
  ARM: dts: imx6q-marsboard: properly define rgmii PHY

 arch/arm/boot/dts/imx6dl-riotboard.dts | 16 +++++++++++++++-
 arch/arm/boot/dts/imx6q-marsboard.dts  | 15 ++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

-- 
2.25.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-03-16  2:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 10:25 [PATCH v2 0/2] properly define some of PHYs Oleksij Rempel
2020-03-13 10:25 ` [PATCH v3 1/2] ARM: dts: imx6dl-riotboard: properly define rgmii PHY Oleksij Rempel
2020-03-13 10:25 ` [PATCH v3 2/2] ARM: dts: imx6q-marsboard: " Oleksij Rempel
2020-03-13 17:50   ` Andrew Lunn
2020-03-16  2:47 ` [PATCH v2 0/2] properly define some of PHYs Shawn Guo
  -- strict thread matches above, loose matches on Subject: below --
2020-03-13  5:32 Oleksij Rempel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).