From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 971F8C2BB1D for ; Fri, 13 Mar 2020 12:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71C9C2073E for ; Fri, 13 Mar 2020 12:55:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbgCMMz2 (ORCPT ); Fri, 13 Mar 2020 08:55:28 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:55781 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726216AbgCMMz2 (ORCPT ); Fri, 13 Mar 2020 08:55:28 -0400 Received: from ip5f5bf7ec.dynamic.kabel-deutschland.de ([95.91.247.236] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jCjqW-0003KZ-PQ; Fri, 13 Mar 2020 12:55:24 +0000 Date: Fri, 13 Mar 2020 13:55:23 +0100 From: Christian Brauner To: Kees Cook Cc: Greg Kroah-Hartman , Todd Kjos , ard.biesheuvel@linaro.org, ardb@kernel.org, john.stultz@linaro.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, naresh.kamboju@linaro.org, shuah@kernel.org, Arve =?utf-8?B?SGrDuG5uZXbDpWc=?= , Martijn Coenen , Joel Fernandes , hridya@google.com, kernel-team@android.com Subject: Re: [PATCH 3/3] binderfs_test: switch from /dev to /tmp as mountpoint Message-ID: <20200313125523.f5yfeyslodp4b7vx@wittgenstein> References: <20200311105309.1742827-1-christian.brauner@ubuntu.com> <20200312131531.3615556-1-christian.brauner@ubuntu.com> <20200312131531.3615556-3-christian.brauner@ubuntu.com> <202003121653.4BC2D43@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <202003121653.4BC2D43@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 04:54:25PM -0700, Kees Cook wrote: > On Thu, Mar 12, 2020 at 02:15:31PM +0100, Christian Brauner wrote: > > Unprivileged users will be able to create directories in there. The > > unprivileged test for /dev wouldn't have worked on most systems. > > > > Signed-off-by: Christian Brauner > > Seems good. (Though would a dynamic location be better? > mkstemp()-style?) Yeah, when I originally wrote binderfs that was really more of a test-stub than anything else. I'll see if I can switch to something less hard-coded. :)