From: Mark Brown <broonie@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl
Date: Fri, 13 Mar 2020 13:29:27 +0000 [thread overview]
Message-ID: <20200313132927.GH5528@sirena.org.uk> (raw)
In-Reply-To: <20200313131635.GA28281@b29397-desktop>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On Fri, Mar 13, 2020 at 01:16:31PM +0000, Peter Chen wrote:
> Most of pins for controlling fixed regulator on or off is GPIO, but how
> GPIO driver handles this? We usually configure pin as GPIO function at
> its user's node (Eg, reset pin for most drivers), but not GPIO node,
The GPIO driver knows what signals it's supposed to be generating, it
should be able to configure pins for this. Setting the pinctrl stuff on
the consumer seems like for example setting the pinctrl for a SPI
controller on the SPI device rather than the controller device which
would be a bit weird.
> GPIO node is usually per SoC, not per board level.
Sure, and it's totally normal for boards to add configuration to nodes
that are part of the SoC. Again I'm a bit confused about why GPIOs are
expected to be different here.
> So, I am wondering why fixed regulator can't have a pin in pinctrl.
> If you grep the dts, there are already several fixed regulator has
> pinctrl.
Obviously those pinctrl settings currently don't actually do anything...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-03-13 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 10:38 [PATCH 1/1] regulator: fixed: add system pm routines for pinctrl Peter Chen
2020-03-12 11:47 ` Mark Brown
2020-03-12 13:00 ` Peter Chen
2020-03-12 14:37 ` Mark Brown
2020-03-12 15:03 ` Peter Chen
2020-03-12 15:07 ` Mark Brown
2020-03-13 3:08 ` Peter Chen
2020-03-13 12:11 ` Mark Brown
2020-03-13 13:16 ` Peter Chen
2020-03-13 13:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313132927.GH5528@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).