* [PATCH -next] rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp
@ 2020-03-13 11:38 Qiujun Huang
2020-03-13 13:49 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Qiujun Huang @ 2020-03-13 11:38 UTC (permalink / raw)
To: paulmck
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, rcu,
linux-kernel, Qiujun Huang
Found by gcc:
WARNING: modpost: "rcu_tasks_rude_wait_gp" [vmlinux] is a static
EXPORT_SYMBOL_GPL
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
kernel/rcu/tasks.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
index cd071b5d4274..04d3c583a9fc 100644
--- a/kernel/rcu/tasks.h
+++ b/kernel/rcu/tasks.h
@@ -447,7 +447,7 @@ static void rcu_tasks_be_rude(struct work_struct *work)
}
// Wait for one rude RCU-tasks grace period.
-static void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
+void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
{
schedule_on_each_cpu(rcu_tasks_be_rude);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp
2020-03-13 11:38 [PATCH -next] rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp Qiujun Huang
@ 2020-03-13 13:49 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2020-03-13 13:49 UTC (permalink / raw)
To: Qiujun Huang
Cc: josh, rostedt, mathieu.desnoyers, jiangshanlai, joel, rcu, linux-kernel
On Fri, Mar 13, 2020 at 07:38:10PM +0800, Qiujun Huang wrote:
> Found by gcc:
> WARNING: modpost: "rcu_tasks_rude_wait_gp" [vmlinux] is a static
> EXPORT_SYMBOL_GPL
>
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
Good eyes, thank you!
However, the fix is instead to remove the EXPORT_SYMBOL_GPL(). I will
squash the removal of this line into a04838a348a9 ("rcu-tasks: Add an
RCU-tasks rude variant"), crediting you with catching this bug.
Again, thank you!
Thanx, Paul
> ---
> kernel/rcu/tasks.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h
> index cd071b5d4274..04d3c583a9fc 100644
> --- a/kernel/rcu/tasks.h
> +++ b/kernel/rcu/tasks.h
> @@ -447,7 +447,7 @@ static void rcu_tasks_be_rude(struct work_struct *work)
> }
>
> // Wait for one rude RCU-tasks grace period.
> -static void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
> +void rcu_tasks_rude_wait_gp(struct rcu_tasks *rtp)
> {
> schedule_on_each_cpu(rcu_tasks_be_rude);
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-13 13:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-13 11:38 [PATCH -next] rcu-tasks: fix a modpost warning for rcu_tasks_rude_wait_gp Qiujun Huang
2020-03-13 13:49 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).