From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Doug Ledford <dledford@redhat.com>,
Gal Pressman <galpress@amazon.com>,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
Mark Zhang <markz@mellanox.com>,
Yishai Hadas <yishaih@mellanox.com>
Subject: Re: [PATCH rdma-next v1 00/11] Add Enhanced Connection Established (ECE)
Date: Fri, 13 Mar 2020 16:00:06 +0200 [thread overview]
Message-ID: <20200313140006.GJ31504@unreal> (raw)
In-Reply-To: <20200313135303.GA25305@ziepe.ca>
On Fri, Mar 13, 2020 at 10:53:03AM -0300, Jason Gunthorpe wrote:
> On Tue, Mar 10, 2020 at 11:14:27AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Changelog:
> > v1: Dropped field_avail patch in favor of mass conversion to use function
> > which already exists in the kernel code.
> > v0: https://lore.kernel.org/lkml/20200305150105.207959-1-leon@kernel.org
> >
> > Enhanced Connection Established or ECE is new negotiation scheme
> > introduced in IBTA v1.4 to exchange extra information about nodes
> > capabilities and later negotiate them at the connection establishment
> > phase.
> >
> > The RDMA-CM messages (REQ, REP, SIDR_REQ and SIDR_REP) were extended
> > to carry two fields, one new and another gained new functionality:
> > * VendorID is a new field that indicates that common subset of vendor
> > option bits are supported as indicated by that VendorID.
> > * AttributeModifier already exists, but overloaded to indicate which
> > vendor options are supported by this VendorID.
> >
> > This is kernel part of such functionality which is responsible to get data
> > from librdmacm and properly create and handle RDMA-CM messages.
> >
> > Thanks
> >
> > Leon Romanovsky (11):
> > RDMA/mlx4: Delete duplicated offsetofend implementation
> > RDMA/mlx5: Use offsetofend() instead of duplicated variant
> > RDMA/cm: Delete not implemented CM peer to peer communication
>
> These ones applied to for-next
Thanks
>
> > RDMA/efa: Use in-kernel offsetofend() to check field availability
>
> This needs resending
I'm not convinced yet.
>
> > RDMA/cm: Add Enhanced Connection Establishment (ECE) bits
> > RDMA/uapi: Add ECE definitions to UCMA
> > RDMA/ucma: Extend ucma_connect to receive ECE parameters
> > RDMA/ucma: Deliver ECE parameters through UCMA events
> > RDMA/cm: Send and receive ECE parameter over the wire
> > RDMA/cma: Connect ECE to rdma_accept
> > RDMA/cma: Provide ECE reject reason
>
> These need userspace to not be RFC
Sure, thanks.
>
> Jason
prev parent reply other threads:[~2020-03-13 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 9:14 [PATCH rdma-next v1 00/11] Add Enhanced Connection Established (ECE) Leon Romanovsky
2020-03-13 13:53 ` Jason Gunthorpe
2020-03-13 14:00 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313140006.GJ31504@unreal \
--to=leon@kernel.org \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markz@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).