From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A7AEC4CECE for ; Fri, 13 Mar 2020 15:01:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E63ED2072C for ; Fri, 13 Mar 2020 15:01:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584111669; bh=go0P9fgXXPo35byt8AV+LGj/xg18Op3eY2CFhsORJbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=h5/kBeIMTuZAjry8vSG06Jd78Vbs0NN9kfEo2HSGy4KsNT6jy7K3Ovs2que7v0NYm 9wgI0pq0eetAt2I9ilG2fyJlB93RvbCv+k1PoJ6WskVKOZWXTEwJU7JCRp4RpsOtyo GYNBNMXsfiPXjvnt6tP9R2g3RU3OmOAz/fkZjpys= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726754AbgCMPBH (ORCPT ); Fri, 13 Mar 2020 11:01:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49180 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbgCMPBH (ORCPT ); Fri, 13 Mar 2020 11:01:07 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AE9A206FA; Fri, 13 Mar 2020 15:01:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584111666; bh=go0P9fgXXPo35byt8AV+LGj/xg18Op3eY2CFhsORJbE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K8rHC7e/bxxQzKqrId1m+K6LiZKbq8lWuCi+yqYhcaquiz7IwFvkE+RyrH5wmKj+K 3PM2wJT/oiPPYgA904Uke6d4R4y/gv9hly5h282sNqtwBzQ8k2YwnM1AHtyuC1vInn 5AA/nxabwg1lwVt/qWLsvpxMKNnkjPhdQ1La/phw= Date: Fri, 13 Mar 2020 11:01:05 -0400 From: Sasha Levin To: Tim Harvey Cc: Linus Walleij , stable@vger.kernel.org, Robert Richter , Lokesh Vutla , "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] gpio: thunderx: fix irq_request_resources Message-ID: <20200313150105.GF1349@sasha-vm> References: <1583941433-15876-1-git-send-email-tharvey@gateworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2020 at 10:16:40AM -0700, Tim Harvey wrote: >On Thu, Mar 12, 2020 at 6:42 AM Linus Walleij wrote: >> >> On Wed, Mar 11, 2020 at 4:43 PM Tim Harvey wrote: >> >> > If there are no parent resources do not call irq_chip_request_resources_parent >> > at all as this will return an error. >> > >> > This resolves a regression where devices using a thunderx gpio as an interrupt >> > would fail probing. >> > >> > Fixes: 0d04d0c ("gpio: thunderx: Use the default parent apis for {request,release}_resources") >> > Signed-off-by: Tim Harvey >> >> This patch does not apply to the mainline kernel or v5.6-rc1. >> >> Please verify: >> 1. If the problem is still in v5.6 (we refactored the driver to >> use GPIOLIB_IRQCHIP) > >Linus, > >Sorry, another issue was keeping me from being able to boot 5.6-rc but >that's now understood and I can confirm the issue is not present in >v5.6-rc5 > >> >> 2. If not, only propose it for linux-stable v5.5 etc. >> > >Yes, needs to be applied to v5.2, v5.3, v5.4, v5.5. I cc'd stable. If >I need to re-submit please let me know. > >Cc: stable@vger.kernel.org Linus, could you ack this patch for stable? -- Thanks, Sasha