From: Sergey Semin <Sergey.Semin@baikalelectronics.ru>
To: Rob Herring <robh@kernel.org>
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Mark Rutland <mark.rutland@arm.com>,
Maxim Kaurkin <maxim.kaurkin@baikalelectronics.ru>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Paul Burton <paulburton@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>, <linux-hwmon@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add Baikal-T1 PVT sensor bindings
Date: Sat, 14 Mar 2020 00:36:53 +0300 [thread overview]
Message-ID: <20200313213652.tfw257cce6sshz2j@ubsrv2.baikal.int> (raw)
In-Reply-To: <20200312221304.GA31909@bogus>
On Thu, Mar 12, 2020 at 05:13:04PM -0500, Rob Herring wrote:
> On Fri, Mar 06, 2020 at 04:26:03PM +0300, Sergey.Semin@baikalelectronics.ru wrote:
> > From: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> >
> > Baikal-T1 SoC is equipped with an embedded process, voltage and
> > temperature sensor to monitor the chip internal environment like
> > temperature, supply voltage and transistors performance.
> >
> > This bindings describes the external Baikal-T1 PVT control interfaces
> > like MMIO registers space, interrupt request number and clocks source.
> > These are then used by the corresponding hwmon device driver to
> > implement the sysfs files-based access to the sensors functionality.
> >
> > Signed-off-by: Maxim Kaurkin <maxim.kaurkin@baikalelectronics.ru>
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> > Signed-off-by: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Paul Burton <paulburton@kernel.org>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > ---
> > .../devicetree/bindings/hwmon/be,bt1-pvt.yaml | 100 ++++++++++++++++++
> > 1 file changed, 100 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/hwmon/be,bt1-pvt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/be,bt1-pvt.yaml b/Documentation/devicetree/bindings/hwmon/be,bt1-pvt.yaml
> > new file mode 100644
> > index 000000000000..d575d124d538
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/be,bt1-pvt.yaml
> > @@ -0,0 +1,100 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual license
>
Ok. I'll add BSD-2-Clause here.
> > +#
> > +# Copyright (C) 2019 BAIKAL ELECTRONICS, JSC
> > +#
> > +# Baikal-T1 Process, Voltage, Temperature Sensor Device Tree Bindings.
>
> drop
>
Ok.
> > +#
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/be,bt1-pvt.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Baikal-T1 PVT Sensor Device Tree Bindings
> > +
> > +maintainers:
> > + - Serge Semin <fancer.lancer@gmail.com>
> > +
> > +description: |
> > + Baikal-T1 SoC provides an embedded process, voltage and temperature
> > + sensor to monitor an internal SoC environment (chip temperature, supply
> > + voltage and process monitor) and on time detect critical situations,
> > + which may cause the system instability and even damages. The IP-block
> > + is based on the Analog Bits PVT sensor, but is equipped with a dedicated
> > + control wrapper, which provides a MMIO registers-based access to the
> > + sensor core functionality (APB3-bus based) and exposes an additional
> > + functions like thresholds/data ready interrupts, its status and masks,
> > + measurements timeout. Its internal structure is depicted on the next
> > + diagram:
> > + Analog Bits core Bakal-T1 PVT control block
> > + +--------------------+ +------------------------+
> > + | Temperature sensor |-+ +------| Sensors control |
> > + |--------------------| |<---En---| |------------------------|
> > + | Voltage sensor |-|<--Mode--| +--->| Sampled data |
> > + |--------------------| |<--Trim--+ | |------------------------|
> > + | Low-Vt sensor |-| | +--| Thresholds comparator |
> > + |--------------------| |---Data----| | |------------------------|
> > + | High-Vt sensor |-| | +->| Interrupts status |
> > + |--------------------| |--Valid--+-+ | |------------------------|
> > + | Standard-Vt sensor |-+ +---+--| Interrupts mask |
> > + +--------------------+ |------------------------|
> > + ^ | Interrupts timeout |
> > + | +------------------------+
> > + | ^ ^
> > + Rclk-----+----------------------------------------+ |
> > + APB3-------------------------------------------------+
> > +
> > + This bindings describes the external Baikal-T1 PVT control interfaces
> > + like MMIO registers space, interrupt request number and clocks source.
> > + These are then used by the corresponding hwmon device driver to
> > + implement the sysfs files-based access to the sensors functionality.
> > +
> > +properties:
> > + compatible:
> > + const: be,bt1-pvt
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + clocks:
> > + items:
> > + - description: PVT reference clock.
> > + - description: APB3 interface clock.
> > +
> > + clock-names:
> > + items:
> > + - const: ref
> > + - const: pclk
> > +
> > + "#thermal-sensor-cells":
> > + description: Baikal-T1 can be referenced as the CPU thermal-sensor.
> > + const: 0
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - clocks
> > + - clock-names
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/mips-gic.h>
> > + #include <dt-bindings/clock/bt1-ccu.h>
> > +
> > + pvt: pvt@1F200000 {
>
> lowercase hex
>
Ok. I'll also remove the bt1-ccu.h inclusion here, since that header
doesn't exist in the kernel source tree at the moment.
Regards,
-Sergey
> > + compatible = "be,bt1-pvt";
> > + reg = <0x1F200000 0x1000>;
> > + #thermal-sensor-cells = <0>;
> > +
> > + interrupts = <GIC_SHARED 31 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + clocks = <&ccu_sys CCU_SYS_PVT_CLK>,
> > + <&ccu_sys CCU_SYS_APB_CLK>;
> > + clock-names = "ref", "pclk";
> > + };
> > +...
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-03-13 21:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200306132604.14312-1-Sergey.Semin@baikalelectronics.ru>
2020-03-06 13:26 ` [PATCH 1/2] dt-bindings: hwmon: Add Baikal-T1 PVT sensor bindings Sergey.Semin
2020-03-12 22:13 ` Rob Herring
2020-03-13 21:36 ` Sergey Semin [this message]
2020-03-06 13:26 ` [PATCH 2/2] hwmon: Add Baikal-T1 PVT sensor driver Sergey.Semin
2020-03-10 0:25 ` [PATCH 0/2] hwmon: Add Baikal-T1 SoC Process, Voltage and Temp sensor support Sergey Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313213652.tfw257cce6sshz2j@ubsrv2.baikal.int \
--to=sergey.semin@baikalelectronics.ru \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=maxim.kaurkin@baikalelectronics.ru \
--cc=paulburton@kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).