From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E751C0044D for ; Sun, 15 Mar 2020 02:06:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 623AD2051A for ; Sun, 15 Mar 2020 02:06:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727521AbgCOCGX (ORCPT ); Sat, 14 Mar 2020 22:06:23 -0400 Received: from v6.sk ([167.172.42.174]:49692 "EHLO v6.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727151AbgCOCGW (ORCPT ); Sat, 14 Mar 2020 22:06:22 -0400 Received: from localhost (v6.sk [IPv6:::1]) by v6.sk (Postfix) with ESMTP id 159A160EED; Sat, 14 Mar 2020 16:38:42 +0000 (UTC) Date: Sat, 14 Mar 2020 17:38:39 +0100 From: Lubomir Rintel To: Kishon Vijay Abraham I Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] phy: Add USB HSIC PHY driver for Marvell MMP3 SoC Message-ID: <20200314163839.GA356953@furthur.local> References: <20200309125848.547664-1-lkundrak@v3.sk> <0d141fd7-274f-e9da-7cd0-68eb026d5c3c@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d141fd7-274f-e9da-7cd0-68eb026d5c3c@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2020 at 04:52:00PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On 09/03/20 6:28 pm, Lubomir Rintel wrote: > > Add PHY driver for the HSICs found on Marvell MMP3 SoC. The driver is > > rather straightforward -- the PHY essentially just needs to be enabled. > > > > Signed-off-by: Lubomir Rintel > > --- > > drivers/phy/marvell/Kconfig | 12 +++++ > > drivers/phy/marvell/Makefile | 1 + > > drivers/phy/marvell/phy-mmp3-hsic.c | 82 +++++++++++++++++++++++++++++ > > 3 files changed, 95 insertions(+) > > create mode 100644 drivers/phy/marvell/phy-mmp3-hsic.c > > ... > > diff --git a/drivers/phy/marvell/phy-mmp3-hsic.c b/drivers/phy/marvell/phy-mmp3-hsic.c > > new file mode 100644 > > index 0000000000000..f7b430f6f6f05 > > --- /dev/null > > +++ b/drivers/phy/marvell/phy-mmp3-hsic.c ... > > +static const struct of_device_id mmp3_hsic_phy_of_match[] = { > > + { .compatible = "marvell,mmp3-hsic-phy", }, > > Where is the binding documentation for this? There's one in mainline: Documentation/devicetree/bindings/phy/marvell,mmp3-hsic-phy.yaml It got added just to document the compatible string at the time I thought usb-nop-xceiv would be sufficient to support the hardware. It needs some fixing -- the "reset-gpios" shouldn't be there. I'll follow up with a patch that removes it; please let me know if anything else needs to be fixed there. > Thanks > Kishon Thank you, Lubo