From: Sergei Trofimovich <slyfox@gentoo.org> To: linux-kernel@vger.kernel.org Cc: Sergei Trofimovich <slyfox@gentoo.org>, Jakub Jelinek <jakub@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>, x86@kernel.org Subject: [PATCH] x86: fix early boot crash on gcc-10 Date: Sat, 14 Mar 2020 16:44:51 +0000 Message-ID: <20200314164451.346497-1-slyfox@gentoo.org> (raw) The change fixes boot failure on physical machine where kernel is built with gcc-10 with stack-protector enabled by default: ``` Kernel panic — not syncing: stack-protector: Kernel stack is corrupted in: start_secondary+0x191/0x1a0 CPU: 1 PID: 0 Comm: swapper/1 Not tainted 5.6.0-rc5—00235—gfffb08b37df9 #139 Hardware name: Gigabyte Technology Co., Ltd. To be filled by O.E.M./H77M—D3H, BIOS F12 11/14/2013 Call Trace: dump_stack+0x71/0xa0 panic+0x107/0x2b8 ? start_secondary+0x191/0x1a0 __stack_chk_fail+0x15/0x20 start_secondary+0x191/0x1a0 secondary_startup_64+0xa4/0xb0 -—-[ end Kernel panic — not syncing: stack—protector: Kernel stack is corrupted in: start_secondary+0x191 ``` This happens because `start_secondary()` is responsible for setting up initial stack canary value in `smpboot.c`, but nothing prevents gcc from inserting stack canary into `start_secondary()` itself before `boot_init_stack_canary()` call. The fix passes `-fno-stack-protector` to avoid any early stack checks in `start_secondary()` or inlined functions into it. Tested the change by successfully booting the machine. A few similar crashes on VMs: - https://bugzilla.redhat.com/show_bug.cgi?id=1796780 - http://rglinuxtech.com/?p=2694 CC: Jakub Jelinek <jakub@redhat.com> CC: Thomas Gleixner <tglx@linutronix.de> CC: Ingo Molnar <mingo@redhat.com> CC: Borislav Petkov <bp@alien8.de> CC: "H. Peter Anvin" <hpa@zytor.com> CC: Andy Lutomirski <luto@kernel.org> CC: x86@kernel.org Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org> --- arch/x86/kernel/Makefile | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile index 9b294c13809a..da9f4ea9bf4c 100644 --- a/arch/x86/kernel/Makefile +++ b/arch/x86/kernel/Makefile @@ -11,6 +11,12 @@ extra-y += vmlinux.lds CPPFLAGS_vmlinux.lds += -U$(UTS_MACHINE) +# smpboot's init_secondary initializes stack canary. +# Make sure we don't emit stack checks before it's +# initialized. +nostackp := $(call cc-option, -fno-stack-protector) +CFLAGS_smpboot.o := $(nostackp) + ifdef CONFIG_FUNCTION_TRACER # Do not profile debug and lowlevel utilities CFLAGS_REMOVE_tsc.o = -pg -- 2.25.1
next reply index Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-14 16:44 Sergei Trofimovich [this message] 2020-03-16 13:04 ` Peter Zijlstra 2020-03-16 13:26 ` Jakub Jelinek 2020-03-16 13:42 ` Peter Zijlstra 2020-03-16 17:54 ` Borislav Petkov 2020-03-16 18:03 ` Jakub Jelinek 2020-03-17 14:36 ` Borislav Petkov 2020-03-17 14:39 ` Jakub Jelinek 2020-03-17 14:49 ` Borislav Petkov 2020-03-17 16:35 ` David Laight 2020-03-25 13:31 ` Borislav Petkov 2020-03-26 21:54 ` Sergei Trofimovich 2020-03-26 22:35 ` Borislav Petkov 2020-03-28 8:48 ` [PATCH v2] " Sergei Trofimovich 2020-04-13 14:15 ` [tip: x86/urgent] x86: Fix " tip-bot2 for Sergei Trofimovich 2020-04-13 16:35 ` [PATCH v2] x86: fix " Borislav Petkov 2020-04-14 13:50 ` Michael Matz 2020-04-15 7:48 ` Borislav Petkov 2020-04-15 14:53 ` Michael Matz 2020-04-15 22:19 ` Sergei Trofimovich 2020-04-17 7:57 ` Borislav Petkov 2020-04-17 8:07 ` Jakub Jelinek 2020-04-17 8:42 ` Borislav Petkov 2020-04-17 8:58 ` Jakub Jelinek 2020-04-17 9:09 ` Borislav Petkov 2020-04-17 18:15 ` Nick Desaulniers 2020-04-17 18:22 ` Nick Desaulniers 2020-04-17 19:06 ` Jakub Jelinek 2020-04-17 19:49 ` Nick Desaulniers 2020-04-17 19:53 ` Nick Desaulniers 2020-04-20 14:04 ` Michael Matz 2020-04-22 10:23 ` Borislav Petkov 2020-04-22 11:40 ` Peter Zijlstra 2020-04-22 13:49 ` Borislav Petkov 2020-04-22 13:55 ` Jakub Jelinek 2020-04-22 14:16 ` Martin Liška 2020-04-22 15:06 ` Michael Matz 2020-04-22 16:53 ` Borislav Petkov 2020-04-22 17:02 ` Jakub Jelinek 2020-04-22 18:47 ` Nick Desaulniers 2020-04-22 18:55 ` Nick Desaulniers 2020-04-22 19:21 ` Borislav Petkov 2020-04-22 21:05 ` Nick Desaulniers 2020-04-22 21:26 ` Borislav Petkov 2020-04-22 22:57 ` Nick Desaulniers 2020-04-23 12:53 ` Borislav Petkov 2020-04-23 16:12 ` [PATCH] x86: Fix early boot crash on gcc-10, next try Borislav Petkov 2020-04-23 17:30 ` Borislav Petkov 2020-04-23 18:02 ` Nick Desaulniers 2020-04-23 18:27 ` Borislav Petkov 2020-04-27 11:37 ` [tip: x86/build] x86/build: Check whether the compiler is sane tip-bot2 for Borislav Petkov 2020-04-23 19:40 ` [PATCH] x86: Fix early boot crash on gcc-10, next try Kees Cook 2020-04-25 1:46 ` Arvind Sankar 2020-04-25 8:57 ` Borislav Petkov 2020-04-25 11:09 ` Jürgen Groß 2020-04-25 15:04 ` Arvind Sankar 2020-04-25 17:31 ` Borislav Petkov 2020-04-25 17:52 ` Borislav Petkov 2020-04-27 17:07 ` David Laight 2020-04-25 18:37 ` Segher Boessenkool 2020-04-25 18:53 ` Borislav Petkov 2020-04-25 19:15 ` Segher Boessenkool 2020-04-25 22:17 ` Borislav Petkov 2020-04-25 22:25 ` Arvind Sankar 2020-04-17 10:38 ` [PATCH v2] x86: fix early boot crash on gcc-10 Peter Zijlstra 2020-04-18 13:12 ` David Laight 2020-04-17 10:41 ` Peter Zijlstra 2020-03-16 18:20 ` [PATCH] " Arvind Sankar 2020-03-16 18:54 ` Arvind Sankar 2020-03-16 19:53 ` Arvind Sankar 2020-03-16 20:08 ` Jakub Jelinek 2020-03-16 20:40 ` Arvind Sankar 2020-03-16 22:12 ` Sergei Trofimovich 2020-03-17 11:46 ` Jakub Jelinek 2020-03-17 18:10 ` Sergei Trofimovich 2020-03-16 18:22 ` Arvind Sankar 2020-03-26 23:16 ` [PATCH v2] " Sergei Trofimovich 2020-04-27 11:37 ` [tip: x86/build] x86: Fix early boot crash on gcc-10, next try tip-bot2 for Borislav Petkov 2020-05-15 11:20 ` [tip: x86/urgent] x86: Fix early boot crash on gcc-10, third try tip-bot2 for Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200314164451.346497-1-slyfox@gentoo.org \ --to=slyfox@gentoo.org \ --cc=bp@alien8.de \ --cc=hpa@zytor.com \ --cc=jakub@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git