From: Eric Biggers <ebiggers@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Vander Stoep <jeffv@google.com>,
Jessica Yu <jeyu@kernel.org>, Kees Cook <keescook@chromium.org>,
Luis Chamberlain <mcgrof@kernel.org>, NeilBrown <neilb@suse.com>
Subject: [PATCH v3 0/5] module autoloading fixes and cleanups
Date: Sat, 14 Mar 2020 14:34:21 -0700 [thread overview]
Message-ID: <20200314213426.134866-1-ebiggers@kernel.org> (raw)
This series fixes a bug where request_module() was reporting success to
kernel code when module autoloading had been completely disabled via
'echo > /proc/sys/kernel/modprobe'.
It also addresses the issues raised on the original thread
(https://lkml.kernel.org/lkml/20200310223731.126894-1-ebiggers@kernel.org/T/#u)
by documenting the modprobe sysctl, adding a self-test for the empty
path case, and downgrading a user-reachable WARN_ONCE().
Changed since v2:
- Adjusted the new documentation to avoid implicitly bringing up
module aliases, which are a more complex topic.
- Split the selftest patch into two patches, one to fix the test
numbering bug and one to add the new tests.
Changed since v1:
- Added patches to address the other issues raised on the thread.
Eric Biggers (5):
kmod: make request_module() return an error when autoloading is
disabled
fs/filesystems.c: downgrade user-reachable WARN_ONCE() to
pr_warn_once()
docs: admin-guide: document the kernel.modprobe sysctl
selftests: kmod: fix handling test numbers above 9
selftests: kmod: test disabling module autoloading
Documentation/admin-guide/sysctl/kernel.rst | 25 +++++++++++-
fs/filesystems.c | 4 +-
kernel/kmod.c | 4 +-
tools/testing/selftests/kmod/kmod.sh | 43 +++++++++++++++++++--
4 files changed, 68 insertions(+), 8 deletions(-)
--
2.25.1
next reply other threads:[~2020-03-15 2:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-14 21:34 Eric Biggers [this message]
2020-03-14 21:34 ` [PATCH v3 1/5] kmod: make request_module() return an error when autoloading is disabled Eric Biggers
2020-03-18 16:03 ` Jessica Yu
2020-03-14 21:34 ` [PATCH v3 2/5] fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once() Eric Biggers
2020-03-17 22:30 ` Sasha Levin
2020-03-18 15:09 ` Jessica Yu
2020-03-18 22:55 ` Eric Biggers
2020-03-18 15:43 ` Jessica Yu
2020-03-18 22:54 ` Eric Biggers
2020-03-14 21:34 ` [PATCH v3 3/5] docs: admin-guide: document the kernel.modprobe sysctl Eric Biggers
2020-03-14 21:34 ` [PATCH v3 4/5] selftests: kmod: fix handling test numbers above 9 Eric Biggers
2020-03-14 21:34 ` [PATCH v3 5/5] selftests: kmod: test disabling module autoloading Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200314213426.134866-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffv@google.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).