linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Haishuang Yan <yanhaishuang@cmss.chinamobile.com>
Cc: Jozsef Kadlecsik <kadlec@netfilter.org>,
	Florian Westphal <fw@strlen.de>,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] netfilter: nf_flow_table: reload ipv6h in nf_flow_nat_ipv6
Date: Sun, 15 Mar 2020 21:44:35 +0100	[thread overview]
Message-ID: <20200315204435.25kji3x5me72xjgg@salvia> (raw)
In-Reply-To: <1584281705-26228-1-git-send-email-yanhaishuang@cmss.chinamobile.com>

On Sun, Mar 15, 2020 at 10:15:02PM +0800, Haishuang Yan wrote:
> Since nf_flow_snat_port and nf_flow_snat_ipv6 call pskb_may_pull()
> which may change skb->data, so we need to reload ipv6h at the right
> palce.

Could you collapse patch 1/4 and 2/4 ?

Same thing with patches 3/4 and 4/4 ?

Thanks.

  parent reply	other threads:[~2020-03-15 20:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-15 14:15 [PATCH 1/4] netfilter: nf_flow_table: reload ipv6h in nf_flow_nat_ipv6 Haishuang Yan
2020-03-15 14:15 ` [PATCH 2/4] netfilter: nf_flow_table: reload iph in nf_flow_nat_ip Haishuang Yan
2020-03-15 14:15 ` [PATCH 3/4] netfilter: nf_flow_table: reload ipv6h in nf_flow_tuple_ipv6 Haishuang Yan
2020-03-15 14:15 ` [PATCH 4/4] netfilter: nf_flow_table: reload iph in nf_flow_tuple_ip Haishuang Yan
2020-03-15 20:44 ` Pablo Neira Ayuso [this message]
2020-03-16  1:12   ` [PATCH 1/4] netfilter: nf_flow_table: reload ipv6h in nf_flow_nat_ipv6 Haishuang Yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200315204435.25kji3x5me72xjgg@salvia \
    --to=pablo@netfilter.org \
    --cc=coreteam@netfilter.org \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=yanhaishuang@cmss.chinamobile.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).