From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: at91: support atomic write xfer
Date: Mon, 16 Mar 2020 15:42:21 +0100 [thread overview]
Message-ID: <20200316144221.GC19141@qmqm.qmqm.pl> (raw)
In-Reply-To: <9924dd54-dd8b-d130-9607-2bbbc65675d5@gmail.com>
On Sun, Mar 15, 2020 at 11:46:33PM +0300, Dmitry Osipenko wrote:
> 15.03.2020 21:27, Michał Mirosław пишет:
> > Implement basic support for atomic write - enough to get a simple
> > write to PMIC on shutdown. Only for chips having ALT_CMD register,
> > eg. SAMA5D2.
> >
> > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > ---
>
> Hello Michał,
>
> ...
> > + ret = pm_runtime_get_sync(dev->dev);
> > + if (ret < 0)
> > + goto out;
>
> Runtime PM can't be used while interrupts are disabled, unless
> pm_runtime_irq_safe() is used and driver's RPM callback is IRQ-safe.
I didn't get any warnings from lockdep and friends, but I'll double
check if this is by luck.
> ...
> > + timeout = jiffies + (2 + msg->len) * HZ/1000;
> > + for (;;) {
> > + stat = at91_twi_read(dev, AT91_TWI_SR);
> > + if (stat & AT91_TWI_TXCOMP)
> > + break;
> > + if (time_after(jiffies, timeout)) {
> > + ret = -ETIMEDOUT;
> > + goto out;
> > + }
> > + udelay(100);
> > + }
>
> Jiffies can't be used with the disabled interrupts because jiffies are
> updated by timer's interrupt.
>
> Either ktime() API or iterator-based loop should be used.
Thanks for the pointers. In my use-case power is cut from the CPU at this
point so it didn't matter that the loop was infinite.
Best Regards
Michał Mirosław
next prev parent reply other threads:[~2020-03-16 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-15 18:27 [PATCH] i2c: at91: support atomic write xfer Michał Mirosław
2020-03-15 20:46 ` Dmitry Osipenko
2020-03-16 14:42 ` Michał Mirosław [this message]
2020-03-16 17:20 ` Stefan Lengfeld
2020-03-16 20:43 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316144221.GC19141@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=alexandre.belloni@bootlin.com \
--cc=digetx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=nicolas.ferre@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).