From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD835C0044D for ; Mon, 16 Mar 2020 15:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 643B520663 for ; Mon, 16 Mar 2020 15:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SuBjR7SX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731716AbgCPPmT (ORCPT ); Mon, 16 Mar 2020 11:42:19 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:45759 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731554AbgCPPmT (ORCPT ); Mon, 16 Mar 2020 11:42:19 -0400 Received: by mail-wr1-f68.google.com with SMTP id t2so11769221wrx.12 for ; Mon, 16 Mar 2020 08:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EuH2JuinWmp99M5kgpRBVbGMWPMpSteTL2l8ALHXOxA=; b=SuBjR7SXVaKqCALkd1H8UtvNwExNZJ6zJgrMM6mOmR/V8duV2z/Ny/rgwl/ICWYmHv RWBK+M3PyiJlb3+IMItQHsDQF5jSLhvuAHwNcv6LMVHk4wOfYJKCJcuzotqrz3dAGYH1 ZoMfxYPhj1aGisNVytbbz16FGd19F/GLWWKqmyz5QVUWCH852OZkHrnPPIWPrqC4neyS a7v3wobNSSlJVCWjnzCdEU/vJKwAqNo9QlJDdZZzhe6JJt9HI/Adz/aIlbUVRlVc5+r/ Wh3K+T1U8mRgzEN73lsQyDrC/jgt58bTBPttxWkvcuF/uHNDyFjl6FzCmQvD6Dy4PO5f 8Mtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EuH2JuinWmp99M5kgpRBVbGMWPMpSteTL2l8ALHXOxA=; b=LP9U5u4BDH5h/Tgnp83XtZxMjiGuO6n7oz5Is1zzvywAp6AlJHGuOqzoGOYhW7Xysq uiaOwI8/juCnVvOI9f1WiA3Zld/zJBfavpWA+fB9R1LYmr/7dHYf+LHyEEHdJGdOZUe2 c8rtP3IGyUSgO6iFZ3e1yU6CfUw4Rc7eqrb+0hAcxe1BHb4Hrs+lB7yLJvGuuw6xY8rv PLFNsndiqqTf4r6qkuMXuen3zqny6fMbcAn/8ewoizAjf4OS11oXfImhmR3aAPQn7FdL N7E/tapOp0ILKSeso7H/xD0YM7IOzWDqypY5JpC5OjB7dHk5zB7BIS6iHsXXmodHH6aN GPCw== X-Gm-Message-State: ANhLgQ0l3THsudhW7F2WCoTdm1+wO+4hL5RewC81ZXhkoA0CkSWsBF90 FV1FZhaEygUnya4kdZLpGQDoaQ== X-Google-Smtp-Source: ADFU+vtvdsyytNA9HXn2kU8Gc/Wj/vUyTOW35SEjh5aHAlAPKupONXAmkHYxA+n8rH6jwZStjuAuGg== X-Received: by 2002:adf:9e8b:: with SMTP id a11mr9088wrf.32.1584373337353; Mon, 16 Mar 2020 08:42:17 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id y80sm85174wmc.45.2020.03.16.08.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:42:16 -0700 (PDT) Date: Mon, 16 Mar 2020 16:42:09 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel Subject: Re: [PATCH 03/15] drm/msm/mdp5: Remove direct access of dev->iommu_fwspec Message-ID: <20200316154209.GD304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-4-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310091229.29830-4-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 10:12:17AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the accessor functions instead of directly dereferencing > dev->iommu_fwspec. > > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index e43ecd4be10a..1252e1d76340 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -725,7 +725,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > > if (config->platform.iommu) { > iommu_dev = &pdev->dev; > - if (!iommu_dev->iommu_fwspec) > + if (!dev_iommu_fwspec_get(iommu_dev)) > iommu_dev = iommu_dev->parent; > > aspace = msm_gem_address_space_create(iommu_dev, > -- > 2.17.1 >