From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DB38C0044D for ; Mon, 16 Mar 2020 15:43:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DFBB20663 for ; Mon, 16 Mar 2020 15:43:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gEq8/ZMB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731852AbgCPPnK (ORCPT ); Mon, 16 Mar 2020 11:43:10 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37500 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731744AbgCPPnJ (ORCPT ); Mon, 16 Mar 2020 11:43:09 -0400 Received: by mail-wr1-f68.google.com with SMTP id 6so21825210wre.4 for ; Mon, 16 Mar 2020 08:43:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=DdvuxQV8MUJ3DF0txatG/PoeJXobhfl8uAplHUnRQXw=; b=gEq8/ZMBwfLkBD9tGRHGjZfTd20HP1xHo/lJCYGOxGAYI7JgVG9jMowKPQSyqmQoJH Q9ZbaY7SOKJp8K4eyLHZOG5BXM7bIz0LDg0iLZ0C7XwnSZgO4Q7ql/grJgyu+f0XKKiZ 8hj2Hl5fh1i6wP+q7uq/YnEi3K13FYNSMiMBiMDb9rTjtVKuKwTX2bq22JmdTliOTXP2 K+5zCU0/1lWFBSvTXbDx9fEkSA/zS7i5vKY3n2XrAijwrJW7uI1+D+Ab8wO+LOpxCjFg cLiZ+CoMaM/7tmWRw/RxFAOt/xBIBCD8p1Ekq22vHH0ospnbZ5362hTq6dFil73T5VxH cAwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=DdvuxQV8MUJ3DF0txatG/PoeJXobhfl8uAplHUnRQXw=; b=XpPGxm3gqRFQ/eji6RqU9OK2CyFJiyaZb/kf++o1sQKEXPOSypxqfFU47a6pWkCvVB DITcReVP1G910dSRGdnHoJpzGPiu28gRTccxOCeLUL1qn4izSr0Fai0aWiX0/9LB6ncb eJlPuJe15MqrHo9ST4PhVzKocadeChX7mesOz7tOhpgPeZUmdD9L0+5yf1ChfA6nr1DN 75ebyCa0Hk9CKiRH52CxhzKBlcmkSzrYXGGW8x17HJhw+H847M+kuPyruu+8+BMVmm23 TtzRWR84yDqTjhUD8i5IC81WBiKJj/+xuyuHq18rrtMINpAFMDa3hFGIm6tl49cMQk2I 9Hjw== X-Gm-Message-State: ANhLgQ2yNy1GwYAupWx3PA8aVX8tJ6xYOCjydwpFZ0vE58lqmjCBB/1F jqUL5hiqZiMHnXeZaoylXjULEw== X-Google-Smtp-Source: ADFU+vukGMBSU+PIquYB6P7V4T5BWKneai54XgateQmlyq1EDcQ3i3rP1F+AK6w2nNtuc0TA4HUjIw== X-Received: by 2002:a5d:43cc:: with SMTP id v12mr35844297wrr.125.1584373387505; Mon, 16 Mar 2020 08:43:07 -0700 (PDT) Received: from myrica ([2001:171b:226b:54a0:116c:c27a:3e7f:5eaf]) by smtp.gmail.com with ESMTPSA id h13sm433117wrv.39.2020.03.16.08.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 08:43:07 -0700 (PDT) Date: Mon, 16 Mar 2020 16:42:59 +0100 From: Jean-Philippe Brucker To: Joerg Roedel Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, virtualization@lists.linux-foundation.org, Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Rob Clark , Sean Paul , Will Deacon , Robin Murphy , Matthias Brugger , Thierry Reding , Andy Gross , Bjorn Andersson , Joerg Roedel Subject: Re: [PATCH 04/15] iommu/tegra-gart: Remove direct access of dev->iommu_fwspec Message-ID: <20200316154259.GE304669@myrica> References: <20200310091229.29830-1-joro@8bytes.org> <20200310091229.29830-5-joro@8bytes.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200310091229.29830-5-joro@8bytes.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2020 at 10:12:18AM +0100, Joerg Roedel wrote: > From: Joerg Roedel > > Use the accessor functions instead of directly dereferencing > dev->iommu_fwspec. > > Signed-off-by: Joerg Roedel Reviewed-by: Jean-Philippe Brucker > --- > drivers/iommu/tegra-gart.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iommu/tegra-gart.c b/drivers/iommu/tegra-gart.c > index 3fb7ba72507d..db6559e8336f 100644 > --- a/drivers/iommu/tegra-gart.c > +++ b/drivers/iommu/tegra-gart.c > @@ -247,7 +247,7 @@ static int gart_iommu_add_device(struct device *dev) > { > struct iommu_group *group; > > - if (!dev->iommu_fwspec) > + if (!dev_iommu_fwspec_get(dev)) > return -ENODEV; > > group = iommu_group_get_for_dev(dev); > -- > 2.17.1 >