From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/9] x86/quirks: Convert DMI matching to use a table
Date: Mon, 16 Mar 2020 17:54:15 +0200 [thread overview]
Message-ID: <20200316155415.GT1922688@smile.fi.intel.com> (raw)
In-Reply-To: <874kuo9v6l.fsf@ashishki-desk.ger.corp.intel.com>
On Mon, Mar 16, 2020 at 05:27:30PM +0200, Alexander Shishkin wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>
> > +static const struct dmi_system_id x86_machine_table[] __initconst = {
> > + {
> > + .ident = "x86 Apple Macintosh",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Inc."),
> > + },
> > + .driver_data = &x86_apple_machine,
> > + },
> > + {
> > + .ident = "x86 Apple Macintosh",
> > + .matches = {
> > + DMI_MATCH(DMI_SYS_VENDOR, "Apple Computer, Inc."),
> > + },
> > + .driver_data = &x86_apple_machine,
> > + },
> > + {}
> > +};
> > +
> > +static void __init early_platform_detect_quirk(void)
> > +{
> > + const struct dmi_system_id *id;
> > +
> > + id = dmi_first_match(x86_machine_table);
> > + if (!id)
> > + return;
> > +
> > + printk(KERN_DEBUG "Detected %s platform\n", id->ident);
> > + *((bool *)id->driver_data) = true;
>
> I'd suggest that x86_apple_machine and the ones that you add further
> down this patchset, be made functions instead. That way you could at
> first hide the global bool(s) and then replace this with something a
> little more type safe.
I'm not sure we will get any benefit of the proposed change. Also it will be
more intrusive since we have dozen of modules that are using it in the form of
exported boolean.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-16 15:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 11:22 [PATCH v3 0/9] x86: Easy way of detecting MS Surface 3 Andy Shevchenko
2020-01-22 11:22 ` [PATCH v3 1/9] x86/platform: Rename x86/apple.h -> x86/machine.h Andy Shevchenko
2020-01-22 11:22 ` [PATCH v3 2/9] x86/quirks: Add missed include to satisfy static checker Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 3/9] x86/quirks: Introduce hpet_dev_print_force_hpet_address() helper Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 4/9] x86/quirks: Join string literals back Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 5/9] x86/quirks: Convert DMI matching to use a table Andy Shevchenko
2020-03-16 15:27 ` Alexander Shishkin
2020-03-16 15:54 ` Andy Shevchenko [this message]
2020-01-22 11:23 ` [PATCH v3 6/9] x86/quirks: Add a DMI quirk for Microsoft Surface 3 Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 7/9] platform/x86: surface3_wmi: Switch DMI table match to a test of variable Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 8/9] ASoC: rt5645: " Andy Shevchenko
2020-01-22 11:23 ` [PATCH v3 9/9] ASoC: Intel: " Andy Shevchenko
2020-02-14 14:24 ` [PATCH v3 0/9] x86: Easy way of detecting MS Surface 3 Andy Shevchenko
2020-03-16 15:33 ` Alexander Shishkin
2020-03-16 15:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316155415.GT1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).