From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 246E0C2BB1D for ; Tue, 17 Mar 2020 11:09:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E789A206EC for ; Tue, 17 Mar 2020 11:09:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443390; bh=7dx3zFjLp/kz4Eo9FTGgZ8jdAx4ycmo7KZ3UhlG8kLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FSMVbAy2gD7jXtj9Dkohc+XUpKZ1zx1OuhAsVhrqtQqrBy63sdC/mnPe5dK0Qnxz4 41XFOg+1fnsPK57uaxPevXVnmKneXO89cZjD0mYURKydC7tw/PimK81asdAsGQo+AP /1d1fVfkmQzD2Y8k4NnKVrTzZvz4aAFDNMCr74D8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728405AbgCQLJs (ORCPT ); Tue, 17 Mar 2020 07:09:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:52300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728980AbgCQLJq (ORCPT ); Tue, 17 Mar 2020 07:09:46 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A3B78205ED; Tue, 17 Mar 2020 11:09:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443386; bh=7dx3zFjLp/kz4Eo9FTGgZ8jdAx4ycmo7KZ3UhlG8kLI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=USRB3LjC+YwAn5Inn1EGPNI+Nk3XQ2Wbt4+rhRi8RfTotb6++82BekRW/FY1KDgo5 ZUj8yFpRd/b2KG1Db1op51jYffDE43+TDmgbJ8ionuV2jEiumHUewet6mmu3ege0Ve toWXEE3lkSdxYZ3E2q6QnQcGHwUZLKJuadOgjybo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Wiedmann , "David S. Miller" Subject: [PATCH 5.5 067/151] s390/qeth: dont reset default_out_queue Date: Tue, 17 Mar 2020 11:54:37 +0100 Message-Id: <20200317103331.268594801@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103326.593639086@linuxfoundation.org> References: <20200317103326.593639086@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Wiedmann [ Upstream commit 240c1948491b81cfe40f84ea040a8f2a4966f101 ] When an OSA device in prio-queue setup is reduced to 1 TX queue due to HW restrictions, we reset its the default_out_queue to 0. In the old code this was needed so that qeth_get_priority_queue() gets the queue selection right. But with proper multiqueue support we already reduced dev->real_num_tx_queues to 1, and so the stack puts all traffic on txq 0 without even calling .ndo_select_queue. Thus we can preserve the user's configuration, and apply it if the OSA device later re-gains support for multiple TX queues. Fixes: 73dc2daf110f ("s390/qeth: add TX multiqueue support for OSA devices") Signed-off-by: Julian Wiedmann Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/s390/net/qeth_core_main.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -1244,7 +1244,6 @@ static int qeth_osa_set_output_queues(st if (count == 1) dev_info(&card->gdev->dev, "Priority Queueing not supported\n"); - card->qdio.default_out_queue = single ? 0 : QETH_DEFAULT_QUEUE; card->qdio.no_out_queues = count; return 0; }