From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDAFC10F29 for ; Tue, 17 Mar 2020 11:12:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B60F20658 for ; Tue, 17 Mar 2020 11:12:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443540; bh=eYg53x1h58f7rl41capUo+qEjljpXzc3lYnFJUdcGOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=mts3iDrQ2R7jYxKXddGVVwaAxT76FX8RlnI56VKkrwa69itLpJ+1NZZ+ixuoeaQYQ 15crGz6n5Kep9Wh78V/bZRii+MZ2XuH3uRerokSbmeKbtCGOxIUIPLfJJ+xiYzmTRX wUo0Zqu/M9pGOitqPbisEuPa/f2z2STv6ODPlzHE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729404AbgCQLMT (ORCPT ); Tue, 17 Mar 2020 07:12:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:55876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729183AbgCQLMQ (ORCPT ); Tue, 17 Mar 2020 07:12:16 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C529320658; Tue, 17 Mar 2020 11:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443535; bh=eYg53x1h58f7rl41capUo+qEjljpXzc3lYnFJUdcGOw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AUNrEY0Nrana9z5RZHkq/UjnzRR2YHV9gDhOyXKoCDBhnY68WOr/C1xVp1nCqCFoP TS+UHDDoLVfF3GM812VgrE77nkvJX9N7kbphXh1Th9fvry9O4JmkTOEJ8oHQsJZbYU iG2YjbmTa+grwd6tz4S4R9gQGwxQDTypc9dNQZas= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladis Dronov , Ard Biesheuvel , Ingo Molnar Subject: [PATCH 5.5 114/151] efi: Add a sanity check to efivar_store_raw() Date: Tue, 17 Mar 2020 11:55:24 +0100 Message-Id: <20200317103334.571691754@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103326.593639086@linuxfoundation.org> References: <20200317103326.593639086@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladis Dronov commit d6c066fda90d578aacdf19771a027ed484a79825 upstream. Add a sanity check to efivar_store_raw() the same way efivar_{attr,size,data}_read() and efivar_show_raw() have it. Signed-off-by: Vladis Dronov Signed-off-by: Ard Biesheuvel Signed-off-by: Ingo Molnar Cc: Link: https://lore.kernel.org/r/20200305084041.24053-3-vdronov@redhat.com Link: https://lore.kernel.org/r/20200308080859.21568-25-ardb@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/efi/efivars.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -208,6 +208,9 @@ efivar_store_raw(struct efivar_entry *en u8 *data; int err; + if (!entry || !buf) + return -EINVAL; + if (in_compat_syscall()) { struct compat_efi_variable *compat;