From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CD56C18E5B for ; Tue, 17 Mar 2020 12:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E010C20767 for ; Tue, 17 Mar 2020 12:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584447022; bh=65/fM+J2X8INN2iOJ0b87ii6F5d/TjeoaQqIweJDJ80=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ra9eC89sOdAMwBVc1y6TBJRm8HqFMl2HHlOhJLXTXgAqIR79gs8Ac0IWa29xU10qH mqYvWKwRv+K+d7xXhp2xstqnkJgVDQsDX13RlmfRdB6HV6Mc2fXD0RBIwIRL34x6wW ulJoTQ/S2O494T+drQmmhd42IG3MwCZQovFeU/Hw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgCQMKV (ORCPT ); Tue, 17 Mar 2020 08:10:21 -0400 Received: from foss.arm.com ([217.140.110.172]:36308 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgCQMKU (ORCPT ); Tue, 17 Mar 2020 08:10:20 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22C4B30E; Tue, 17 Mar 2020 05:10:20 -0700 (PDT) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9A1C53F534; Tue, 17 Mar 2020 05:10:19 -0700 (PDT) Date: Tue, 17 Mar 2020 12:10:18 +0000 From: Mark Brown To: Douglas Anderson Cc: Alok Chauhan , Dilip Kota , skakit@codeaurora.org, Girish Mahadevan , Andy Gross , Bjorn Andersson , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH] spi: spi-geni-qcom: Speculative fix of "nobody cared" about interrupt Message-ID: <20200317121018.GB3971@sirena.org.uk> References: <20200316151939.1.I752ebdcfd5e8bf0de06d66e767b8974932b3620e@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="24zk1gE8NUlDmwG9" Content-Disposition: inline In-Reply-To: <20200316151939.1.I752ebdcfd5e8bf0de06d66e767b8974932b3620e@changeid> X-Cookie: There's only one everything. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --24zk1gE8NUlDmwG9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 16, 2020 at 03:20:01PM -0700, Douglas Anderson wrote: > + /* > + * We don't expect to hit this, but if we do we should try our best > + * to clear the interrupts and return so we don't just get called > + * again. > + */ > + if (mas->cur_mcmd == CMD_NONE) > + goto exit; > + Does this mean that there was an actual concrete message of type CMD_NONE or does it mean that there was no message waiting? If there was no message then isn't the interrupt spurious? --24zk1gE8NUlDmwG9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl5wvikACgkQJNaLcl1U h9CCWAf+NrJf9Q2fJM35MGcoGUs8HYyVUL+NopJOwpbgEbzsTaDN+rMUwFyy9/3t EKFyp3Im6x70GXrpQHs5emVrYuNt8oDcn0CDY29pXq8qGuCkAFnlMufGj4dfrQA6 /XQD0gIuvduh6qKndbhRVeVUFdiTyKKeqiCim4eAld/CTfIyyulDPo6KEVVHYt4X kJG/dz10WQ8oyRBckFTD1HtTPsA7TJT34V2ll71CvJcmCWZRAwLzmD9MbZRTdrv+ J3IHwcyJp9XSTIaSBJhxizMzdz4BH4fhLSR/yQDBruEFZIzbTBskk2QOJ77qZG8k w0I9PWvjgN5EGCRPLk4M+HgIHbJTfw== =eX8I -----END PGP SIGNATURE----- --24zk1gE8NUlDmwG9--