From: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
To: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org
Cc: "Paul Barker" <pbarker@konsulko.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Marcel Ziswiler" <marcel.ziswiler@toradex.com>,
"Igor Opaniuk" <igor.opaniuk@toradex.com>,
"Philippe Schenker" <philippe.schenker@toradex.com>,
"Oleksandr Suvorov" <oleksandr.suvorov@toradex.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Kevin Hilman" <khilman@baylibre.com>,
"Ludovic Desroches" <ludovic.desroches@microchip.com>,
"Maxime Ripard" <mripard@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Paul Cercueil" <paul@crapouillou.net>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Ray Jui" <rjui@broadcom.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Scott Branden" <sbranden@broadcom.com>,
"Shawn Guo" <shawnguo@kernel.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Tony Prisk" <linux@prisktech.co.nz>,
bcm-kernel-feedback-list@broadcom.com,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum
Date: Tue, 17 Mar 2020 14:32:25 +0200 [thread overview]
Message-ID: <20200317123231.2843297-2-oleksandr.suvorov@toradex.com> (raw)
In-Reply-To: <20200317123231.2843297-1-oleksandr.suvorov@toradex.com>
The polarity enum definition PWM_POLARITY_INVERSED is misspelled.
Rename it to PWM_POLARITY_INVERTED.
Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@toradex.com>
---
drivers/pwm/core.c | 4 ++--
drivers/pwm/pwm-atmel-hlcdc.c | 2 +-
drivers/pwm/pwm-atmel-tcb.c | 16 ++++++++--------
drivers/pwm/pwm-atmel.c | 2 +-
drivers/pwm/pwm-bcm-iproc.c | 2 +-
drivers/pwm/pwm-bcm-kona.c | 2 +-
drivers/pwm/pwm-ep93xx.c | 2 +-
drivers/pwm/pwm-fsl-ftm.c | 2 +-
drivers/pwm/pwm-hibvt.c | 2 +-
drivers/pwm/pwm-imx-tpm.c | 2 +-
drivers/pwm/pwm-imx27.c | 4 ++--
drivers/pwm/pwm-jz4740.c | 2 +-
drivers/pwm/pwm-meson.c | 6 +++---
drivers/pwm/pwm-omap-dmtimer.c | 4 ++--
drivers/pwm/pwm-renesas-tpu.c | 6 +++---
drivers/pwm/pwm-rockchip.c | 4 ++--
drivers/pwm/pwm-sifive.c | 4 ++--
drivers/pwm/pwm-sun4i.c | 2 +-
drivers/pwm/pwm-tiecap.c | 2 +-
drivers/pwm/pwm-tiehrpwm.c | 4 ++--
drivers/pwm/pwm-vt8500.c | 2 +-
drivers/pwm/pwm-zx.c | 4 ++--
drivers/pwm/sysfs.c | 4 ++--
include/linux/pwm.h | 4 ++--
24 files changed, 44 insertions(+), 44 deletions(-)
diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c
index 5a7f6598c05f..08afbb5b98aa 100644
--- a/drivers/pwm/core.c
+++ b/drivers/pwm/core.c
@@ -152,7 +152,7 @@ of_pwm_xlate_with_flags(struct pwm_chip *pc, const struct of_phandle_args *args)
pwm->args.polarity = PWM_POLARITY_NORMAL;
if (args->args_count > 2 && args->args[2] & PWM_POLARITY_INVERTED)
- pwm->args.polarity = PWM_POLARITY_INVERSED;
+ pwm->args.polarity = PWM_POLARITY_INVERTED;
return pwm;
}
@@ -819,7 +819,7 @@ static struct pwm_device *acpi_pwm_get(struct fwnode_handle *fwnode)
pwm->args.polarity = PWM_POLARITY_NORMAL;
if (args.nargs > 2 && args.args[2] & PWM_POLARITY_INVERTED)
- pwm->args.polarity = PWM_POLARITY_INVERSED;
+ pwm->args.polarity = PWM_POLARITY_INVERTED;
#endif
return pwm;
diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
index dcbc0489dfd4..b53a188479b0 100644
--- a/drivers/pwm/pwm-atmel-hlcdc.c
+++ b/drivers/pwm/pwm-atmel-hlcdc.c
@@ -270,7 +270,7 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
chip->chip.of_xlate = of_pwm_xlate_with_flags;
chip->chip.of_pwm_n_cells = 3;
- ret = pwmchip_add_with_polarity(&chip->chip, PWM_POLARITY_INVERSED);
+ ret = pwmchip_add_with_polarity(&chip->chip, PWM_POLARITY_INVERTED);
if (ret) {
clk_disable_unprepare(hlcdc->periph_clk);
return ret;
diff --git a/drivers/pwm/pwm-atmel-tcb.c b/drivers/pwm/pwm-atmel-tcb.c
index 85c53701958c..98526a286347 100644
--- a/drivers/pwm/pwm-atmel-tcb.c
+++ b/drivers/pwm/pwm-atmel-tcb.c
@@ -152,7 +152,7 @@ static void atmel_tcb_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
/*
* If duty is 0 the timer will be stopped and we have to
* configure the output correctly on software trigger:
- * - set output to high if PWM_POLARITY_INVERSED
+ * - set output to high if PWM_POLARITY_INVERTED
* - set output to low if PWM_POLARITY_NORMAL
*
* This is why we're reverting polarity in this case.
@@ -166,13 +166,13 @@ static void atmel_tcb_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
/* flush old setting and set the new one */
if (index == 0) {
cmr &= ~ATMEL_TC_ACMR_MASK;
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_ASWTRG_CLEAR;
else
cmr |= ATMEL_TC_ASWTRG_SET;
} else {
cmr &= ~ATMEL_TC_BCMR_MASK;
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_BSWTRG_CLEAR;
else
cmr |= ATMEL_TC_BSWTRG_SET;
@@ -211,7 +211,7 @@ static int atmel_tcb_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
/*
* If duty is 0 the timer will be stopped and we have to
* configure the output correctly on software trigger:
- * - set output to high if PWM_POLARITY_INVERSED
+ * - set output to high if PWM_POLARITY_INVERTED
* - set output to low if PWM_POLARITY_NORMAL
*
* This is why we're reverting polarity in this case.
@@ -229,13 +229,13 @@ static int atmel_tcb_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
cmr &= ~ATMEL_TC_ACMR_MASK;
/* Set CMR flags according to given polarity */
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_ASWTRG_CLEAR;
else
cmr |= ATMEL_TC_ASWTRG_SET;
} else {
cmr &= ~ATMEL_TC_BCMR_MASK;
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_BSWTRG_CLEAR;
else
cmr |= ATMEL_TC_BSWTRG_SET;
@@ -249,12 +249,12 @@ static int atmel_tcb_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
*/
if (tcbpwm->duty != tcbpwm->period && tcbpwm->duty > 0) {
if (index == 0) {
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_ACPA_SET | ATMEL_TC_ACPC_CLEAR;
else
cmr |= ATMEL_TC_ACPA_CLEAR | ATMEL_TC_ACPC_SET;
} else {
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
cmr |= ATMEL_TC_BCPB_SET | ATMEL_TC_BCPC_CLEAR;
else
cmr |= ATMEL_TC_BCPB_CLEAR | ATMEL_TC_BCPC_SET;
diff --git a/drivers/pwm/pwm-atmel.c b/drivers/pwm/pwm-atmel.c
index 6161e7e3e9ac..2d42f97e4b81 100644
--- a/drivers/pwm/pwm-atmel.c
+++ b/drivers/pwm/pwm-atmel.c
@@ -329,7 +329,7 @@ static void atmel_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
}
if (cmr & PWM_CMR_CPOL)
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
else
state->polarity = PWM_POLARITY_NORMAL;
}
diff --git a/drivers/pwm/pwm-bcm-iproc.c b/drivers/pwm/pwm-bcm-iproc.c
index 1f829edd8ee7..574bec61e0ac 100644
--- a/drivers/pwm/pwm-bcm-iproc.c
+++ b/drivers/pwm/pwm-bcm-iproc.c
@@ -97,7 +97,7 @@ static void iproc_pwmc_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
if (value & BIT(IPROC_PWM_CTRL_POLARITY_SHIFT(pwm->hwpwm)))
state->polarity = PWM_POLARITY_NORMAL;
else
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
value = readl(ip->base + IPROC_PWM_PRESCALE_OFFSET);
prescale = value >> IPROC_PWM_PRESCALE_SHIFT(pwm->hwpwm);
diff --git a/drivers/pwm/pwm-bcm-kona.c b/drivers/pwm/pwm-bcm-kona.c
index 81da91df2529..02da511814f1 100644
--- a/drivers/pwm/pwm-bcm-kona.c
+++ b/drivers/pwm/pwm-bcm-kona.c
@@ -303,7 +303,7 @@ static int kona_pwmc_probe(struct platform_device *pdev)
clk_disable_unprepare(kp->clk);
- ret = pwmchip_add_with_polarity(&kp->chip, PWM_POLARITY_INVERSED);
+ ret = pwmchip_add_with_polarity(&kp->chip, PWM_POLARITY_INVERTED);
if (ret < 0)
dev_err(&pdev->dev, "failed to add PWM chip: %d\n", ret);
diff --git a/drivers/pwm/pwm-ep93xx.c b/drivers/pwm/pwm-ep93xx.c
index 4bab73073ad7..02345b6f9fe8 100644
--- a/drivers/pwm/pwm-ep93xx.c
+++ b/drivers/pwm/pwm-ep93xx.c
@@ -124,7 +124,7 @@ static int ep93xx_pwm_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
if (ret)
return ret;
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
writew(0x1, ep93xx_pwm->base + EP93XX_PWMx_INVERT);
else
writew(0x0, ep93xx_pwm->base + EP93XX_PWMx_INVERT);
diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c
index 59272a920479..75dc30978c19 100644
--- a/drivers/pwm/pwm-fsl-ftm.c
+++ b/drivers/pwm/pwm-fsl-ftm.c
@@ -287,7 +287,7 @@ static int fsl_pwm_apply_config(struct fsl_pwm_chip *fpc,
regmap_write(fpc->regmap, FTM_CV(pwm->hwpwm), duty);
reg_polarity = 0;
- if (newstate->polarity == PWM_POLARITY_INVERSED)
+ if (newstate->polarity == PWM_POLARITY_INVERTED)
reg_polarity = BIT(pwm->hwpwm);
regmap_update_bits(fpc->regmap, FTM_POL, BIT(pwm->hwpwm), reg_polarity);
diff --git a/drivers/pwm/pwm-hibvt.c b/drivers/pwm/pwm-hibvt.c
index ad205fdad372..c57a94e7da0f 100644
--- a/drivers/pwm/pwm-hibvt.c
+++ b/drivers/pwm/pwm-hibvt.c
@@ -120,7 +120,7 @@ static void hibvt_pwm_set_polarity(struct pwm_chip *chip,
{
struct hibvt_pwm_chip *hi_pwm_chip = to_hibvt_pwm_chip(chip);
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
hibvt_pwm_set_bits(hi_pwm_chip->base, PWM_CTRL_ADDR(pwm->hwpwm),
PWM_POLARITY_MASK, (0x1 << PWM_POLARITY_SHIFT));
else
diff --git a/drivers/pwm/pwm-imx-tpm.c b/drivers/pwm/pwm-imx-tpm.c
index 9145f6160649..461ab2c08616 100644
--- a/drivers/pwm/pwm-imx-tpm.c
+++ b/drivers/pwm/pwm-imx-tpm.c
@@ -156,7 +156,7 @@ static void pwm_imx_tpm_get_state(struct pwm_chip *chip,
/* get polarity */
val = readl(tpm->base + PWM_IMX_TPM_CnSC(pwm->hwpwm));
if ((val & PWM_IMX_TPM_CnSC_ELS) == PWM_IMX_TPM_CnSC_ELS_INVERSED)
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
else
/*
* Assume reserved values (2b00 and 2b11) to yield
diff --git a/drivers/pwm/pwm-imx27.c b/drivers/pwm/pwm-imx27.c
index 35a7ac42269c..33d344445254 100644
--- a/drivers/pwm/pwm-imx27.c
+++ b/drivers/pwm/pwm-imx27.c
@@ -146,7 +146,7 @@ static void pwm_imx27_get_state(struct pwm_chip *chip,
state->polarity = PWM_POLARITY_NORMAL;
break;
case MX3_PWMCR_POUTC_INVERTED:
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
break;
default:
dev_warn(chip->dev, "can't set polarity, output disconnected");
@@ -280,7 +280,7 @@ static int pwm_imx27_apply(struct pwm_chip *chip, struct pwm_device *pwm,
FIELD_PREP(MX3_PWMCR_CLKSRC, MX3_PWMCR_CLKSRC_IPG_HIGH) |
MX3_PWMCR_DBGEN;
- if (state->polarity == PWM_POLARITY_INVERSED)
+ if (state->polarity == PWM_POLARITY_INVERTED)
cr |= FIELD_PREP(MX3_PWMCR_POUTC,
MX3_PWMCR_POUTC_INVERTED);
diff --git a/drivers/pwm/pwm-jz4740.c b/drivers/pwm/pwm-jz4740.c
index 9d78cc21cb12..67075d18561f 100644
--- a/drivers/pwm/pwm-jz4740.c
+++ b/drivers/pwm/pwm-jz4740.c
@@ -130,7 +130,7 @@ static int jz4740_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
case PWM_POLARITY_NORMAL:
ctrl &= ~JZ_TIMER_CTRL_PWM_ACTIVE_LOW;
break;
- case PWM_POLARITY_INVERSED:
+ case PWM_POLARITY_INVERTED:
ctrl |= JZ_TIMER_CTRL_PWM_ACTIVE_LOW;
break;
}
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c
index 6245bbdb6e6c..2d368bfc680d 100644
--- a/drivers/pwm/pwm-meson.c
+++ b/drivers/pwm/pwm-meson.c
@@ -8,7 +8,7 @@
* N cycles for the first half period.
* The hardware has no "polarity" setting. This driver reverses the period
* cycles (the low length is inverted with the high length) for
- * PWM_POLARITY_INVERSED. This means that .get_state cannot read the polarity
+ * PWM_POLARITY_INVERTED. This means that .get_state cannot read the polarity
* from the hardware.
* Setting the duty cycle will disable and re-enable the PWM output.
* Disabling the PWM stops the output immediately (without waiting for the
@@ -168,7 +168,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm,
duty = state->duty_cycle;
period = state->period;
- if (state->polarity == PWM_POLARITY_INVERSED)
+ if (state->polarity == PWM_POLARITY_INVERTED)
duty = period - duty;
fin_freq = clk_get_rate(channel->clk);
@@ -275,7 +275,7 @@ static int meson_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
return -EINVAL;
if (!state->enabled) {
- if (state->polarity == PWM_POLARITY_INVERSED) {
+ if (state->polarity == PWM_POLARITY_INVERTED) {
/*
* This IP block revision doesn't have an "always high"
* setting which we can use for "inverted disabled".
diff --git a/drivers/pwm/pwm-omap-dmtimer.c b/drivers/pwm/pwm-omap-dmtimer.c
index 88a3c5690fea..082ccec93133 100644
--- a/drivers/pwm/pwm-omap-dmtimer.c
+++ b/drivers/pwm/pwm-omap-dmtimer.c
@@ -190,7 +190,7 @@ static int pwm_omap_dmtimer_config(struct pwm_chip *chip,
load_value, load_value, match_value, match_value);
omap->pdata->set_pwm(omap->dm_timer,
- pwm_get_polarity(pwm) == PWM_POLARITY_INVERSED,
+ pwm_get_polarity(pwm) == PWM_POLARITY_INVERTED,
true,
PWM_OMAP_DMTIMER_TRIGGER_OVERFLOW_AND_COMPARE);
@@ -220,7 +220,7 @@ static int pwm_omap_dmtimer_set_polarity(struct pwm_chip *chip,
*/
mutex_lock(&omap->mutex);
omap->pdata->set_pwm(omap->dm_timer,
- polarity == PWM_POLARITY_INVERSED,
+ polarity == PWM_POLARITY_INVERTED,
true,
PWM_OMAP_DMTIMER_TRIGGER_OVERFLOW_AND_COMPARE);
mutex_unlock(&omap->mutex);
diff --git a/drivers/pwm/pwm-renesas-tpu.c b/drivers/pwm/pwm-renesas-tpu.c
index 4a855a21b782..32beeb93ade1 100644
--- a/drivers/pwm/pwm-renesas-tpu.c
+++ b/drivers/pwm/pwm-renesas-tpu.c
@@ -108,17 +108,17 @@ static void tpu_pwm_set_pin(struct tpu_pwm_device *pwm,
switch (state) {
case TPU_PIN_INACTIVE:
tpu_pwm_write(pwm, TPU_TIORn,
- pwm->polarity == PWM_POLARITY_INVERSED ?
+ pwm->polarity == PWM_POLARITY_INVERTED ?
TPU_TIOR_IOA_1 : TPU_TIOR_IOA_0);
break;
case TPU_PIN_PWM:
tpu_pwm_write(pwm, TPU_TIORn,
- pwm->polarity == PWM_POLARITY_INVERSED ?
+ pwm->polarity == PWM_POLARITY_INVERTED ?
TPU_TIOR_IOA_0_SET : TPU_TIOR_IOA_1_CLR);
break;
case TPU_PIN_ACTIVE:
tpu_pwm_write(pwm, TPU_TIORn,
- pwm->polarity == PWM_POLARITY_INVERSED ?
+ pwm->polarity == PWM_POLARITY_INVERTED ?
TPU_TIOR_IOA_0 : TPU_TIOR_IOA_1);
break;
}
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 73352e6fbccb..c6158d559790 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -91,7 +91,7 @@ static void rockchip_pwm_get_state(struct pwm_chip *chip,
true : false;
if (pc->data->supports_polarity && !(val & PWM_DUTY_POSITIVE))
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
else
state->polarity = PWM_POLARITY_NORMAL;
@@ -135,7 +135,7 @@ static void rockchip_pwm_config(struct pwm_chip *chip, struct pwm_device *pwm,
if (pc->data->supports_polarity) {
ctrl &= ~PWM_POLARITY_MASK;
- if (state->polarity == PWM_POLARITY_INVERSED)
+ if (state->polarity == PWM_POLARITY_INVERTED)
ctrl |= PWM_DUTY_NEGATIVE | PWM_INACTIVE_POSITIVE;
else
ctrl |= PWM_DUTY_POSITIVE | PWM_INACTIVE_NEGATIVE;
diff --git a/drivers/pwm/pwm-sifive.c b/drivers/pwm/pwm-sifive.c
index cc63f9baa481..409123405a11 100644
--- a/drivers/pwm/pwm-sifive.c
+++ b/drivers/pwm/pwm-sifive.c
@@ -124,7 +124,7 @@ static void pwm_sifive_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
state->period = ddata->real_period;
state->duty_cycle =
(u64)duty * ddata->real_period >> PWM_SIFIVE_CMPWIDTH;
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
}
static int pwm_sifive_enable(struct pwm_chip *chip, bool enable)
@@ -157,7 +157,7 @@ static int pwm_sifive_apply(struct pwm_chip *chip, struct pwm_device *pwm,
int ret = 0;
u32 frac;
- if (state->polarity != PWM_POLARITY_INVERSED)
+ if (state->polarity != PWM_POLARITY_INVERTED)
return -EINVAL;
ret = clk_enable(ddata->clk);
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 3e3efa6c768f..7ddcdefd2a97 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -149,7 +149,7 @@ static void sun4i_pwm_get_state(struct pwm_chip *chip,
if (val & BIT_CH(PWM_ACT_STATE, pwm->hwpwm))
state->polarity = PWM_POLARITY_NORMAL;
else
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
if ((val & BIT_CH(PWM_CLK_GATING | PWM_EN, pwm->hwpwm)) ==
BIT_CH(PWM_CLK_GATING | PWM_EN, pwm->hwpwm))
diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
index ab38c8203b79..b96b388f0969 100644
--- a/drivers/pwm/pwm-tiecap.c
+++ b/drivers/pwm/pwm-tiecap.c
@@ -118,7 +118,7 @@ static int ecap_pwm_set_polarity(struct pwm_chip *chip, struct pwm_device *pwm,
value = readw(pc->mmio_base + ECCTL2);
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
/* Duty cycle defines LOW period of PWM */
value |= ECCTL2_APWM_POL_LOW;
else
diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
index 7b4c770ce9d6..71c337443dd5 100644
--- a/drivers/pwm/pwm-tiehrpwm.c
+++ b/drivers/pwm/pwm-tiehrpwm.c
@@ -193,7 +193,7 @@ static void configure_polarity(struct ehrpwm_pwm_chip *pc, int chan)
aqctl_reg = AQCTLB;
aqctl_mask = AQCTL_CBU_MASK;
- if (pc->polarity[chan] == PWM_POLARITY_INVERSED)
+ if (pc->polarity[chan] == PWM_POLARITY_INVERTED)
aqctl_val = AQCTL_CHANB_POLINVERSED;
else
aqctl_val = AQCTL_CHANB_POLNORMAL;
@@ -201,7 +201,7 @@ static void configure_polarity(struct ehrpwm_pwm_chip *pc, int chan)
aqctl_reg = AQCTLA;
aqctl_mask = AQCTL_CAU_MASK;
- if (pc->polarity[chan] == PWM_POLARITY_INVERSED)
+ if (pc->polarity[chan] == PWM_POLARITY_INVERTED)
aqctl_val = AQCTL_CHANA_POLINVERSED;
else
aqctl_val = AQCTL_CHANA_POLNORMAL;
diff --git a/drivers/pwm/pwm-vt8500.c b/drivers/pwm/pwm-vt8500.c
index 11d45e56a923..fc434965c5ed 100644
--- a/drivers/pwm/pwm-vt8500.c
+++ b/drivers/pwm/pwm-vt8500.c
@@ -165,7 +165,7 @@ static int vt8500_pwm_set_polarity(struct pwm_chip *chip,
val = readl(vt8500->base + REG_CTRL(pwm->hwpwm));
- if (polarity == PWM_POLARITY_INVERSED)
+ if (polarity == PWM_POLARITY_INVERTED)
val |= CTRL_INVERT;
else
val &= ~CTRL_INVERT;
diff --git a/drivers/pwm/pwm-zx.c b/drivers/pwm/pwm-zx.c
index e2c21cc34a96..dc7d20e52c52 100644
--- a/drivers/pwm/pwm-zx.c
+++ b/drivers/pwm/pwm-zx.c
@@ -75,7 +75,7 @@ static void zx_pwm_get_state(struct pwm_chip *chip, struct pwm_device *pwm,
if (value & ZX_PWM_POLAR)
state->polarity = PWM_POLARITY_NORMAL;
else
- state->polarity = PWM_POLARITY_INVERSED;
+ state->polarity = PWM_POLARITY_INVERTED;
if (value & ZX_PWM_EN)
state->enabled = true;
@@ -158,7 +158,7 @@ static int zx_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
if (state->polarity != cstate.polarity)
zx_pwm_set_mask(zpc, pwm->hwpwm, ZX_PWM_MODE, ZX_PWM_POLAR,
- (state->polarity == PWM_POLARITY_INVERSED) ?
+ (state->polarity == PWM_POLARITY_INVERTED) ?
0 : ZX_PWM_POLAR);
if (state->period != cstate.period ||
diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index 2389b8669846..769ac09c56c2 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -166,7 +166,7 @@ static ssize_t polarity_show(struct device *child,
polarity = "normal";
break;
- case PWM_POLARITY_INVERSED:
+ case PWM_POLARITY_INVERTED:
polarity = "inversed";
break;
}
@@ -187,7 +187,7 @@ static ssize_t polarity_store(struct device *child,
if (sysfs_streq(buf, "normal"))
polarity = PWM_POLARITY_NORMAL;
else if (sysfs_streq(buf, "inversed"))
- polarity = PWM_POLARITY_INVERSED;
+ polarity = PWM_POLARITY_INVERTED;
else
return -EINVAL;
diff --git a/include/linux/pwm.h b/include/linux/pwm.h
index 0ef808d925bb..38b7ed8ef913 100644
--- a/include/linux/pwm.h
+++ b/include/linux/pwm.h
@@ -16,13 +16,13 @@ struct pwm_chip;
* @PWM_POLARITY_NORMAL: a high signal for the duration of the duty-
* cycle, followed by a low signal for the remainder of the pulse
* period
- * @PWM_POLARITY_INVERSED: a low signal for the duration of the duty-
+ * @PWM_POLARITY_INVERTED: a low signal for the duration of the duty-
* cycle, followed by a high signal for the remainder of the pulse
* period
*/
enum pwm_polarity {
PWM_POLARITY_NORMAL,
- PWM_POLARITY_INVERSED,
+ PWM_POLARITY_INVERTED,
};
/**
--
2.24.1
next parent reply other threads:[~2020-03-17 12:32 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200317123231.2843297-1-oleksandr.suvorov@toradex.com>
2020-03-17 12:32 ` Oleksandr Suvorov [this message]
2020-03-17 13:34 ` [RFC PATCH 1/7] pwm: rename the PWM_POLARITY_INVERSED enum Paul Barker
2020-03-17 21:32 ` Uwe Kleine-König
2020-03-17 16:26 ` Claudiu.Beznea
2020-03-17 16:39 ` Oleksandr Suvorov
2020-03-17 17:40 ` Thierry Reding
2020-03-17 21:00 ` Uwe Kleine-König
2020-03-18 22:59 ` Thierry Reding
2020-03-19 6:50 ` Uwe Kleine-König
2020-03-19 16:37 ` Thierry Reding
2020-03-19 17:30 ` Uwe Kleine-König
2020-03-19 11:40 ` Oleksandr Suvorov
2020-03-19 12:10 ` Uwe Kleine-König
2020-03-19 12:57 ` Oleksandr Suvorov
2020-03-19 16:44 ` Thierry Reding
2020-03-18 11:47 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 2/7] dt-bindings: pwm: document the PWM polarity flag Oleksandr Suvorov
2020-03-17 17:43 ` Thierry Reding
2020-03-17 21:30 ` Uwe Kleine-König
2020-03-18 23:05 ` Thierry Reding
2020-03-19 7:05 ` Uwe Kleine-König
2020-03-19 17:04 ` Thierry Reding
2020-03-30 21:00 ` Rob Herring
2020-03-18 23:19 ` Thierry Reding
2020-03-17 22:58 ` Laurent Pinchart
2020-03-17 12:32 ` [RFC PATCH 3/7] dt-bindings: pwm: add normal " Oleksandr Suvorov
2020-03-17 13:36 ` Paul Barker
2020-03-17 14:06 ` Oleksandr Suvorov
2020-03-17 21:36 ` Uwe Kleine-König
2020-03-17 22:56 ` Laurent Pinchart
2020-03-18 9:20 ` Uwe Kleine-König
2020-03-17 12:32 ` [RFC PATCH 4/7] dt-bindings: pwm: add description of PWM polarity Oleksandr Suvorov
2020-03-17 23:01 ` Laurent Pinchart
2020-03-18 11:37 ` Oleksandr Suvorov
2020-03-18 12:29 ` Laurent Pinchart
2020-03-18 12:36 ` Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 5/7] pwm: replace polarity enum with macros Oleksandr Suvorov
2020-03-17 12:32 ` [RFC PATCH 6/7] arm64: dts: pwm: replace polarity constant with macro Oleksandr Suvorov
2020-03-20 10:03 ` Krzysztof Kozlowski
2020-03-17 12:32 ` [RFC PATCH 7/7] arm: " Oleksandr Suvorov
2020-03-20 10:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317123231.2843297-2-oleksandr.suvorov@toradex.com \
--to=oleksandr.suvorov@toradex.com \
--cc=alexandre.belloni@bootlin.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=igor.opaniuk@toradex.com \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@prisktech.co.nz \
--cc=ludovic.desroches@microchip.com \
--cc=marcel.ziswiler@toradex.com \
--cc=mripard@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paul@crapouillou.net \
--cc=pbarker@konsulko.com \
--cc=philippe.schenker@toradex.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).