From: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
To: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch,
sumit.semwal@linaro.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, rodrigosiqueiramelo@gmail.com,
andrealmeid@collabora.com
Subject: Re: [PATCH] Staging: drm_gem: Fix a misaligned comment block
Date: Tue, 17 Mar 2020 09:39:59 -0400 [thread overview]
Message-ID: <20200317133959.pdimegprq3gn4gsf@outlook.office365.com> (raw)
In-Reply-To: <20200316211553.2506-1-igormtorrente@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
Hi Igor,
First of all, thanks for your patch.
Just a few suggestions:
* Avoid using "Fix" in this sort of patch. Usually, we use "Fix" for
indicating a bug fix or similar. You can read more about it here:
https://kernelnewbies.org/PatchPhilosophy
* Patch subject format may vary between subsystem, however, I recommend
you to follow the instructions from this page:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
In summary, I just recommend you to improve the commit subject for your
V2.
Thanks
On 03/16, Igor Matheus Andrade Torrente wrote:
> Fix a checkpatch warning caused by a misaligned comment block.
>
> Signed-off-by: Igor Matheus Andrade Torrente <igormtorrente@gmail.com>
> ---
> drivers/gpu/drm/drm_gem.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
> index 000fa4a1899f..6e960d57371e 100644
> --- a/drivers/gpu/drm/drm_gem.c
> +++ b/drivers/gpu/drm/drm_gem.c
> @@ -222,10 +222,10 @@ drm_gem_object_handle_put_unlocked(struct drm_gem_object *obj)
> return;
>
> /*
> - * Must bump handle count first as this may be the last
> - * ref, in which case the object would disappear before we
> - * checked for a name
> - */
> + * Must bump handle count first as this may be the last
> + * ref, in which case the object would disappear before we
> + * checked for a name
> + */
>
> mutex_lock(&dev->object_name_lock);
> if (--obj->handle_count == 0) {
> --
> 2.20.1
>
--
Rodrigo Siqueira
https://siqueira.tech
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-17 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 21:15 [PATCH] Staging: drm_gem: Fix a misaligned comment block Igor Matheus Andrade Torrente
2020-03-17 13:39 ` Rodrigo Siqueira [this message]
2020-03-17 20:11 ` [PATCH v2] drm: Alligne a " Igor Matheus Andrade Torrente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317133959.pdimegprq3gn4gsf@outlook.office365.com \
--to=rodrigo.siqueira@amd.com \
--cc=airlied@linux.ie \
--cc=andrealmeid@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=igormtorrente@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=rodrigosiqueiramelo@gmail.com \
--cc=sean@poorly.run \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).