From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84E2AC10F29 for ; Tue, 17 Mar 2020 14:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5724A20714 for ; Tue, 17 Mar 2020 14:24:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="0kFAx45h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726680AbgCQOYh (ORCPT ); Tue, 17 Mar 2020 10:24:37 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40892 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbgCQOYh (ORCPT ); Tue, 17 Mar 2020 10:24:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QqvvrmXpnKXQ1ab6Kx0r+TdrHnYQf4gBf8GHV4uqfJw=; b=0kFAx45h60mQxVpDJyndWRiy6r BrIv61JpTNhkfrXurbW3J9mlWIJJJM5yHHJvmzXYqkihUrUBbh1xhMM4wk1LF/5/+rfHx6EOPpdHS k2e5FjZLlYM11fUToB9lh/U7WeO4L+7jo6AZnzM+20biFdU6jb+pUktgc9sDnvC/a+2E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jED8t-0006ud-NO; Tue, 17 Mar 2020 15:24:27 +0100 Date: Tue, 17 Mar 2020 15:24:27 +0100 From: Andrew Lunn To: Chris Packham Cc: davem@davemloft.net, josua@solid-run.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/2] net: mvmdio: avoid error message for optional IRQ Message-ID: <20200317142427.GU24270@lunn.ch> References: <20200316074907.21879-1-chris.packham@alliedtelesis.co.nz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200316074907.21879-1-chris.packham@alliedtelesis.co.nz> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2020 at 08:49:05PM +1300, Chris Packham wrote: > I've gone ahead an sent a revert. This is the same as the original v1 except > I've added Andrew's review to the commit message. Hi Chris Thanks for keeping at this. I took a look at the core code. It would of been better to call this _nowarn, not _optional :-( Andrew