From: Catalin Marinas <catalin.marinas@arm.com>
To: Gavin Shan <gshan@redhat.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, will@kernel.org, maz@kernel.org,
mark.rutland@arm.com, shan.gavin@gmail.com
Subject: Re: [PATCH] arm64/kernel: Simplify __cpu_up() by bailing out early
Date: Tue, 17 Mar 2020 18:32:09 +0000 [thread overview]
Message-ID: <20200317183209.GG632169@arrakis.emea.arm.com> (raw)
In-Reply-To: <20200302020340.119588-1-gshan@redhat.com>
On Mon, Mar 02, 2020 at 01:03:40PM +1100, Gavin Shan wrote:
> The function __cpu_up() is invoked to bring up the target CPU through
> the backend, PSCI for example. The nested if statements won't be needed
> if we bail out early on the following two conditions where the status
> won't be checked. The code looks simplified in that case.
>
> * Error returned from the backend (e.g. PSCI)
> * The target CPU has been marked as onlined
>
> Signed-off-by: Gavin Shan <gshan@redhat.com>
Queued for 5.7. Thanks.
--
Catalin
prev parent reply other threads:[~2020-03-17 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 2:03 [PATCH] arm64/kernel: Simplify __cpu_up() by bailing out early Gavin Shan
2020-03-02 12:21 ` Mark Rutland
2020-03-02 13:38 ` Gavin Shan
2020-03-02 14:06 ` Mark Rutland
2020-03-02 14:35 ` Gavin Shan
2020-03-17 10:06 ` Mark Rutland
2020-03-17 10:08 ` Catalin Marinas
2020-03-17 18:32 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200317183209.GG632169@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=gshan@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=shan.gavin@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).