From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3EDAC5ACD6 for ; Tue, 17 Mar 2020 21:36:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A69DA20738 for ; Tue, 17 Mar 2020 21:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727196AbgCQVgg (ORCPT ); Tue, 17 Mar 2020 17:36:36 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:51209 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727083AbgCQVgg (ORCPT ); Tue, 17 Mar 2020 17:36:36 -0400 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jEJsy-0006fh-Fw; Tue, 17 Mar 2020 22:36:28 +0100 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jEJsy-0004wY-1R; Tue, 17 Mar 2020 22:36:28 +0100 Date: Tue, 17 Mar 2020 22:36:28 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Oleksandr Suvorov Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, Paul Barker , Laurent Pinchart , Marcel Ziswiler , Igor Opaniuk , Philippe Schenker , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/7] dt-bindings: pwm: add normal PWM polarity flag Message-ID: <20200317213627.i2w5a7togr5gh6co@pengutronix.de> References: <20200317123231.2843297-1-oleksandr.suvorov@toradex.com> <20200317123231.2843297-4-oleksandr.suvorov@toradex.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200317123231.2843297-4-oleksandr.suvorov@toradex.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2020 at 02:32:27PM +0200, Oleksandr Suvorov wrote: > PWM can have a normal polarity and a reverted one. The reverted polarity > value is defined. > Define the PWM_POLARITY_NORMAL to be used further. > > Signed-off-by: Oleksandr Suvorov > --- > > include/dt-bindings/pwm/pwm.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h > index ab9a077e3c7d..6b58caa6385e 100644 > --- a/include/dt-bindings/pwm/pwm.h > +++ b/include/dt-bindings/pwm/pwm.h > @@ -10,6 +10,7 @@ > #ifndef _DT_BINDINGS_PWM_PWM_H > #define _DT_BINDINGS_PWM_PWM_H > > +#define PWM_POLARITY_NORMAL 0 > #define PWM_POLARITY_INVERTED (1 << 0) Maybe define PWM_POLARITY_NORMAL as (0 << 0) to make it more obvious that it is the inverse of PWM_POLARITY_INVERTED? But even when kept as is I like hafing PWM_POLARITY_NORMAL in the binding definitions. Acked-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |