From: Wolfram Sang <wsa@the-dreams.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Tang Bin <tangbin@cmss.chinamobile.com>,
linux@rempel-privat.de, s.hauer@pengutronix.de,
shawnguo@kernel.org, linux-i2c@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq()
Date: Wed, 18 Mar 2020 11:44:05 +0100 [thread overview]
Message-ID: <20200318104405.rsqiw5og4xbuv6n5@katana> (raw)
In-Reply-To: <20200318101844.55c273zh242ymxcf@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
Hi Uwe,
> Maybe add a comment for the next person who wonders about an error path
> without error message? Something like:
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> /*
> * platform_get_irq() already issued an error message, so
> * fail silently here.
> */
> return irq;
Hmm, too much boilerplate for my taste. I'd rather assume it will be
printed during the call.
> And to get some extra kudos mention the commit that modified
> platform_get_irq() to emit a message in the commit log.
Yes.
Kind regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-03-18 10:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 10:07 [PATCH] drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq() Tang Bin
2020-03-18 10:18 ` Uwe Kleine-König
2020-03-18 10:44 ` Wolfram Sang [this message]
2020-03-20 12:34 ` Oleksij Rempel
2020-03-21 18:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318104405.rsqiw5og4xbuv6n5@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).