From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B6C2C5ACD7 for ; Wed, 18 Mar 2020 12:29:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62FEF20767 for ; Wed, 18 Mar 2020 12:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Y/spN90e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726740AbgCRM3u (ORCPT ); Wed, 18 Mar 2020 08:29:50 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:44994 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726546AbgCRM3u (ORCPT ); Wed, 18 Mar 2020 08:29:50 -0400 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B40E5F9; Wed, 18 Mar 2020 13:29:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1584534587; bh=gQKuXxEqexrnhnz8x/feE0Di0ED55uUAwf+JiJpuBqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y/spN90eRK3QaYE5+ZxO+buNeicgh1W8rrPIX/HsQOvcZ3uN9rmiFxuI0dbp0b1vC K1JQ6xrmKf86Gyk5BLH3Tmpw5zUcZ3RlkUE+MYTmhyHefS5u2BYAbK7AtJPxSigihk jPLHo1OqgQlNtA+r2vMdak+gThMI29/1R5EViXNg= Date: Wed, 18 Mar 2020 14:29:42 +0200 From: Laurent Pinchart To: Oleksandr Suvorov Cc: devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, Paul Barker , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Marcel Ziswiler , Igor Opaniuk , Philippe Schenker , Rob Herring , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 4/7] dt-bindings: pwm: add description of PWM polarity Message-ID: <20200318122942.GA7833@pendragon.ideasonboard.com> References: <20200317123231.2843297-1-oleksandr.suvorov@toradex.com> <20200317123231.2843297-5-oleksandr.suvorov@toradex.com> <20200317230115.GM2527@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oleksandr, On Wed, Mar 18, 2020 at 01:37:00PM +0200, Oleksandr Suvorov wrote: > On Wed, Mar 18, 2020 at 1:02 AM Laurent Pinchart wrote: > > On Tue, Mar 17, 2020 at 02:32:28PM +0200, Oleksandr Suvorov wrote: > > > Move the description of the PWM signal polarity from > > > , prepare for removing the polarity > > > definition from . > > > > > > Signed-off-by: Oleksandr Suvorov > > > --- > > > > > > include/dt-bindings/pwm/pwm.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/include/dt-bindings/pwm/pwm.h b/include/dt-bindings/pwm/pwm.h > > > index 6b58caa6385e..c07da2088a61 100644 > > > --- a/include/dt-bindings/pwm/pwm.h > > > +++ b/include/dt-bindings/pwm/pwm.h > > > @@ -10,7 +10,16 @@ > > > #ifndef _DT_BINDINGS_PWM_PWM_H > > > #define _DT_BINDINGS_PWM_PWM_H > > > > > > +/** > > > + * a high signal for the duration of the duty-cycle, followed by a low signal > > > + * for the remainder of the pulse period. > > > + */ > > > > Last time I checked, kernedoc didn't support documenting macros (enums > > are supported). > > That's why I dropped the kerneldoc tags leaving the descriptions only. But you forgot to replace /** with /* :-) Sorry for not being clear about what I meant. > > > #define PWM_POLARITY_NORMAL 0 > > > + > > > +/** > > > + * a low signal for the duration of the duty-cycle, followed by a high signal > > > + * for the remainder of the pulse period. > > > + */ > > > #define PWM_POLARITY_INVERTED (1 << 0) > > > > > > #endif -- Regards, Laurent Pinchart