From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8743DC4332D for ; Thu, 19 Mar 2020 17:16:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5CC272070A for ; Thu, 19 Mar 2020 17:16:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728378AbgCSRQb (ORCPT ); Thu, 19 Mar 2020 13:16:31 -0400 Received: from elvis.franken.de ([193.175.24.41]:51419 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727446AbgCSRQb (ORCPT ); Thu, 19 Mar 2020 13:16:31 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jEymJ-0004Hm-00; Thu, 19 Mar 2020 18:16:19 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 5A023C026A; Thu, 19 Mar 2020 17:22:45 +0100 (CET) Date: Thu, 19 Mar 2020 17:22:45 +0100 From: Thomas Bogendoerfer To: Masahiro Yamada Cc: linux-mips@vger.kernel.org, Paul Burton , kbuild-all@lists.01.org, Linux Kbuild mailing list , "sparclinux@vger.kernel.org, David S . Miller" , clang-built-linux , Al Viro , Nick Desaulniers , Ilie Halip , Nathan Chancellor , Linux Kernel Mailing List , Michal Marek , kbuild test robot Subject: Re: [PATCH v2 2/2] kbuild: link lib-y objects to vmlinux forcibly when CONFIG_MODULES=y Message-ID: <20200319162245.GA19404@alpha.franken.de> References: <20200311223725.27662-2-masahiroy@kernel.org> <202003121230.lys3M8E8%lkp@intel.com> <20200312083943.GA7278@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 20, 2020 at 12:48:20AM +0900, Masahiro Yamada wrote: > Hi Thomas, > > On Thu, Mar 12, 2020 at 5:40 PM Thomas Bogendoerfer > wrote: > > > > On Thu, Mar 12, 2020 at 03:12:28PM +0900, Masahiro Yamada wrote: > > > I got the following report from 0-day bot. > > > Please advise me how to fix it. > > > > > > > > > I am not sure how multi-platform works in MIPS. > > > > > > The cavium-octeon platform has its own implementation > > > of various functions. > > > > > > So, vmlinux links different library routines > > > depending on whether CONFIG_CAVIUM_OCTEON_SOC, correct? > > > > for cavium memcpy is directly linked in via octeon-memcpy.o, while for > > every other platform it's coming from lib/lib.a(memcpy.o). > > > > What have you changed, that this doesn't work anymore ? > > > > Thomas. > > > I want to change all objects from lib-y > to be linked to vmlinux (exactly like obj-y ) > if CONFIG_MODULES is enabled. ic > So, annotating __weak is a good solution > (thanks Nick!). > > If I send a patch, is it acceptable? sure. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]