From: Michal Hocko <mhocko@kernel.org>
To: Rik van Riel <riel@surriel.com>
Cc: "Roman Gushchin" <guro@fb.com>, "Aslan Bakirov" <aslan@fb.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-mm@kvack.org, kernel-team@fb.com,
linux-kernel@vger.kernel.org,
"Andreas Schaufler" <andreas.schaufler@gmx.de>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
"Guido Günther" <agx@sigxcpu.org>,
"Naresh Kamboju" <naresh.kamboju@linaro.org>
Subject: Re: [PATCH] mm: hugetlb: fix hugetlb_cma_reserve() if CONFIG_NUMA isn't set
Date: Thu, 19 Mar 2020 18:01:52 +0100 [thread overview]
Message-ID: <20200319170152.GJ20800@dhcp22.suse.cz> (raw)
In-Reply-To: <3f75f55dc6a9b4dfd3c6ac808c370bfd91d1554a.camel@surriel.com>
On Thu 19-03-20 12:56:34, Rik van Riel wrote:
> On Thu, 2020-03-19 at 17:16 +0100, Michal Hocko wrote:
> >
> > This is not the first time HAVE_MEMBLOCK_NODE_MAP has been
> > problematic.
> > I might be missing something but I really do not get why do we really
> > need it these days. As for !NUMA, I suspect we can make it generate
> > the
> > right thing when !NUMA.
>
> We're working on a different fix now.
>
> It looks like cma_declare_contiguous calls memblock_phys_alloc_range,
> which calls memblock_alloc_range_nid, which takes a NUMA node as one
> of its arguments.
>
> Aslan is looking at simply adding a cma_declare_contiguous_nid, which
> also takes a NUMA node ID as an argument. At that point we can simply
> leave CMA free to allocate from anywhere in each NUMA node, which by
> default already happens from the top down.
>
> That should be the nicer long term fix to this issue.
Yes, that sounds like a better solution. Not that I would be much
happier to have HAVE_MEMBLOCK_NODE_MAP off the table as well ;)
Ohh well, it will have to remain on my todo list for some longer.
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2020-03-19 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200318153424.3202304-1-guro@fb.com>
2020-03-18 16:16 ` [PATCH] mm: hugetlb: fix hugetlb_cma_reserve() if CONFIG_NUMA isn't set Michal Hocko
2020-03-18 17:55 ` Roman Gushchin
2020-03-19 16:16 ` Michal Hocko
2020-03-19 16:56 ` Rik van Riel
2020-03-19 17:01 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319170152.GJ20800@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=agx@sigxcpu.org \
--cc=akpm@linux-foundation.org \
--cc=andreas.schaufler@gmx.de \
--cc=aslan@fb.com \
--cc=guro@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=naresh.kamboju@linaro.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).