From: Eric Biggers <ebiggers@kernel.org>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jeff Vander Stoep <jeffv@google.com>,
Jessica Yu <jeyu@kernel.org>, Kees Cook <keescook@chromium.org>,
Luis Chamberlain <mcgrof@kernel.org>, NeilBrown <neilb@suse.com>
Subject: Re: [PATCH v4 0/5] module autoloading fixes and cleanups
Date: Thu, 19 Mar 2020 22:28:19 -0700 [thread overview]
Message-ID: <20200320052819.GB1315@sol.localdomain> (raw)
In-Reply-To: <20200318230515.171692-1-ebiggers@kernel.org>
On Wed, Mar 18, 2020 at 04:05:10PM -0700, Eric Biggers wrote:
> This series fixes a bug where request_module() was reporting success to
> kernel code when module autoloading had been completely disabled via
> 'echo > /proc/sys/kernel/modprobe'.
>
> It also addresses the issues raised on the original thread
> (https://lkml.kernel.org/lkml/20200310223731.126894-1-ebiggers@kernel.org/T/#u)
> by documenting the modprobe sysctl, adding a self-test for the empty
> path case, and downgrading a user-reachable WARN_ONCE().
>
> Changed since v3:
> - Added Fixes tag to the fs/filesystems.c patch, and mentioned why the
> warning is continued to be printed once only.
>
> Changed since v2:
> - Adjusted the new documentation to avoid implicitly bringing up
> module aliases, which are a more complex topic.
> - Split the selftest patch into two patches, one to fix the test
> numbering bug and one to add the new tests.
>
> Changed since v1:
> - Added patches to address the other issues raised on the thread.
It seems that people are relatively happy with this patch series now.
Andrew, will you be taking it through -mm? I don't see any better place.
Thanks,
- Eric
next prev parent reply other threads:[~2020-03-20 5:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 23:05 [PATCH v4 0/5] module autoloading fixes and cleanups Eric Biggers
2020-03-18 23:05 ` [PATCH v4 1/5] kmod: make request_module() return an error when autoloading is disabled Eric Biggers
2020-03-18 23:05 ` [PATCH v4 2/5] fs/filesystems.c: downgrade user-reachable WARN_ONCE() to pr_warn_once() Eric Biggers
2020-03-18 23:05 ` [PATCH v4 3/5] docs: admin-guide: document the kernel.modprobe sysctl Eric Biggers
2020-03-30 18:48 ` Eric Biggers
2020-03-18 23:05 ` [PATCH v4 4/5] selftests: kmod: fix handling test numbers above 9 Eric Biggers
2020-03-18 23:05 ` [PATCH v4 5/5] selftests: kmod: test disabling module autoloading Eric Biggers
2020-03-20 5:28 ` Eric Biggers [this message]
2020-03-21 2:27 ` [PATCH v4 0/5] module autoloading fixes and cleanups Andrew Morton
2020-03-23 17:12 ` Eric Biggers
2020-03-27 17:41 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320052819.GB1315@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jeffv@google.com \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).