From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: tglx@linutronix.de, arnd@arndb.de, balbi@kernel.org,
bhelgaas@google.com, bigeasy@linutronix.de, davem@davemloft.net,
gregkh@linuxfoundation.org, joel@joelfernandes.org,
kurt.schwemmer@microsemi.com, kvalo@codeaurora.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, logang@deltatee.com,
mingo@kernel.org, mpe@ellerman.id.au, netdev@vger.kernel.org,
oleg@redhat.com, paulmck@kernel.org, rdunlap@infradead.org,
rostedt@goodmis.org, torvalds@linux-foundation.org,
will@kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH 17/15] rcuwait: Inform rcuwait_wake_up() users if a wakeup was attempted
Date: Fri, 20 Mar 2020 11:44:26 +0100 [thread overview]
Message-ID: <20200320104426.GD20696@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200320085527.23861-2-dave@stgolabs.net>
On Fri, Mar 20, 2020 at 01:55:25AM -0700, Davidlohr Bueso wrote:
> diff --git a/kernel/exit.c b/kernel/exit.c
> index 6cc6cc485d07..b0bb0a8ec4b1 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -234,9 +234,10 @@ void release_task(struct task_struct *p)
> goto repeat;
> }
>
> -void rcuwait_wake_up(struct rcuwait *w)
> +bool rcuwait_wake_up(struct rcuwait *w)
> {
> struct task_struct *task;
> + bool ret = false;
>
> rcu_read_lock();
>
> @@ -254,10 +255,15 @@ void rcuwait_wake_up(struct rcuwait *w)
> smp_mb(); /* (B) */
>
> task = rcu_dereference(w->task);
> - if (task)
> + if (task) {
> wake_up_process(task);
> + ret = true;
ret = wake_up_process(task); ?
> + }
> rcu_read_unlock();
> +
> + return ret;
> }
> +EXPORT_SYMBOL_GPL(rcuwait_wake_up);
next prev parent reply other threads:[~2020-03-20 10:45 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 20:43 [patch V2 00/15] Lock ordering documentation and annotation for lockdep Thomas Gleixner
2020-03-18 20:43 ` [patch V2 01/15] PCI/switchtec: Fix init_completion race condition with poll_wait() Thomas Gleixner
2020-03-18 21:25 ` Bjorn Helgaas
2020-03-18 20:43 ` [patch V2 02/15] pci/switchtec: Replace completion wait queue usage for poll Thomas Gleixner
2020-03-18 21:26 ` Bjorn Helgaas
2020-03-18 22:11 ` Logan Gunthorpe
2020-03-18 20:43 ` [patch V2 03/15] usb: gadget: Use completion interface instead of open coding it Thomas Gleixner
2020-03-19 8:41 ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 04/15] orinoco_usb: Use the regular completion interfaces Thomas Gleixner
2020-03-19 8:40 ` Greg Kroah-Hartman
2020-03-18 20:43 ` [patch V2 05/15] acpi: Remove header dependency Thomas Gleixner
2020-03-18 20:43 ` [patch V2 06/15] rcuwait: Add @state argument to rcuwait_wait_event() Thomas Gleixner
2020-03-20 5:36 ` Davidlohr Bueso
2020-03-20 8:45 ` Sebastian Andrzej Siewior
2020-03-20 8:58 ` Davidlohr Bueso
2020-03-20 9:48 ` [PATCH 0/5] Remove mm.h from arch/*/include/asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 1/5] nds32: Remove mm.h from asm/uaccess.h Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 2/5] csky: " Sebastian Andrzej Siewior
2020-03-21 11:24 ` Guo Ren
2020-03-21 12:08 ` Thomas Gleixner
2020-03-21 14:11 ` Guo Ren
2020-03-20 9:48 ` [PATCH 3/5] hexagon: " Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 4/5] ia64: " Sebastian Andrzej Siewior
2020-03-20 9:48 ` [PATCH 5/5] microblaze: " Sebastian Andrzej Siewior
2020-03-18 20:43 ` [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait Thomas Gleixner
2020-03-19 9:00 ` Sebastian Andrzej Siewior
2020-03-19 9:18 ` Peter Zijlstra
2020-03-19 9:21 ` Davidlohr Bueso
2020-03-19 10:04 ` Christoph Hellwig
2020-03-19 10:26 ` Sebastian Andrzej Siewior
2020-03-20 0:01 ` Geoff Levand
2020-03-20 0:45 ` Michael Ellerman
2020-03-21 10:41 ` Thomas Gleixner
2020-03-18 20:43 ` [patch V2 08/15] Documentation: Add lock ordering and nesting documentation Thomas Gleixner
2020-03-18 22:31 ` Paul E. McKenney
2020-03-19 18:02 ` Thomas Gleixner
2020-03-20 16:01 ` Paul E. McKenney
2020-03-20 19:51 ` Thomas Gleixner
2020-03-20 21:02 ` Paul E. McKenney
2020-03-20 22:36 ` Thomas Gleixner
2020-03-21 2:29 ` Paul E. McKenney
2020-03-21 10:26 ` Thomas Gleixner
2020-03-21 17:23 ` Paul E. McKenney
2020-03-19 8:51 ` Davidlohr Bueso
2020-03-19 15:04 ` Jonathan Corbet
2020-03-19 18:04 ` Thomas Gleixner
2020-03-21 21:21 ` Joel Fernandes
2020-03-21 21:49 ` Thomas Gleixner
2020-03-22 1:36 ` Joel Fernandes
2020-03-18 20:43 ` [patch V2 09/15] timekeeping: Split jiffies seqlock Thomas Gleixner
2020-03-18 20:43 ` [patch V2 10/15] sched/swait: Prepare usage in completions Thomas Gleixner
2020-03-18 20:43 ` [patch V2 11/15] completion: Use simple wait queues Thomas Gleixner
2020-03-18 22:28 ` Logan Gunthorpe
2020-03-19 0:33 ` Joel Fernandes
2020-03-19 0:44 ` Thomas Gleixner
2020-03-19 8:42 ` Greg Kroah-Hartman
2020-03-19 17:12 ` Linus Torvalds
2020-03-19 23:25 ` Julian Calaby
2020-03-20 6:59 ` Christoph Hellwig
2020-03-20 9:01 ` Davidlohr Bueso
2020-03-18 20:43 ` [patch V2 13/15] lockdep: Add hrtimer context tracing bits Thomas Gleixner
2020-03-18 20:43 ` [patch V2 14/15] lockdep: Annotate irq_work Thomas Gleixner
2020-03-18 20:43 ` [patch V2 15/15] lockdep: Add posixtimer context tracing bits Thomas Gleixner
2020-03-20 8:50 ` [patch V2 00/15] Lock ordering documentation and annotation for lockdep Davidlohr Bueso
2020-03-20 8:55 ` [PATCH 16/15] rcuwait: Get rid of stale name comment Davidlohr Bueso
2020-03-20 8:55 ` [PATCH 17/15] rcuwait: Inform rcuwait_wake_up() users if a wakeup was attempted Davidlohr Bueso
2020-03-20 9:13 ` Sebastian Andrzej Siewior
2020-03-20 10:44 ` Peter Zijlstra [this message]
2020-03-20 8:55 ` [PATCH 18/15] kvm: Replace vcpu->swait with rcuwait Davidlohr Bueso
2020-03-20 11:20 ` Paolo Bonzini
2020-03-20 12:54 ` Peter Zijlstra
2020-03-22 16:33 ` Davidlohr Bueso
2020-03-22 22:32 ` Peter Zijlstra
2020-03-20 8:55 ` [PATCH 19/15] sched/swait: Reword some of the main description Davidlohr Bueso
2020-03-20 9:19 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320104426.GD20696@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=dbueso@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=logang@deltatee.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).