From: Dan Carpenter <dan.carpenter@oracle.com>
To: Camylla Cantanheide <c.cantanheide@gmail.com>
Cc: Joe Perches <joe@perches.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, LKML <linux-kernel@vger.kernel.org>,
lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables
Date: Fri, 20 Mar 2020 14:04:53 +0300 [thread overview]
Message-ID: <20200320110453.GA4672@kadam> (raw)
In-Reply-To: <CAG3pEr+9tuSYw==qgp3J8r--SdAd8DBMNQqSHCZQc-mkVVuE6w@mail.gmail.com>
On Wed, Mar 18, 2020 at 02:31:27PM -0300, Camylla Cantanheide wrote:
> Dear Dan Carpenter and Joe Perches,
>
> Thank you very much for the suggestions, I found the evaluation of both
> very significant. Now, I have another perspective on variables.
>
> I solved the problem for the *setKey *function, however, when executing the
> checkpatch, more *Checks* of the same type appeared.
If your changed introduces more warnings then you should fix them. Like
say you rename variables and now the line goes over 80 characters, then
fix the new 80 character warning. But if it was already over 80
characters then ignore the warning.
>
> Should I send the second version of the patch, only to the *setKey*
> function or do I resolve all *Checks* for the entire file?
We want patches which are easy to review. If you change everything in
the file, it will probably be too complicated for me to review. So I
guess ignore those warnings.
regards,
dan carpenter
prev parent reply other threads:[~2020-03-20 11:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-17 8:51 [PATCH 1/2] staging: rtl8192u: Using function name as string Camylla Goncalves Cantanheide
2020-03-17 8:51 ` [PATCH 2/2] staging: rtl8192u: Corrects 'Avoid CamelCase' for variables Camylla Goncalves Cantanheide
2020-03-17 13:43 ` Dan Carpenter
2020-03-17 15:04 ` Joe Perches
[not found] ` <CAG3pEr+9tuSYw==qgp3J8r--SdAd8DBMNQqSHCZQc-mkVVuE6w@mail.gmail.com>
2020-03-18 17:57 ` Joe Perches
2020-03-20 11:04 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320110453.GA4672@kadam \
--to=dan.carpenter@oracle.com \
--cc=c.cantanheide@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).