Hi Yang, Thank you for the patch! Yet something to improve: [auto build test ERROR on kvm/linux-next] [also build test ERROR on next-20200319] [cannot apply to vhost/linux-next tip/auto-latest linux/master linus/master v5.6-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Yang-Weijiang/Introduce-support-for-guest-CET-feature/20200320-155517 base: https://git.kernel.org/pub/scm/virt/kvm/kvm.git linux-next config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.5.0-5) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot All errors (new ones prefixed by >>): arch/x86/kvm/x86.c: In function 'kvm_set_cr0': arch/x86/kvm/x86.c:809:53: error: 'X86_CR4_CET' undeclared (first use in this function); did you mean 'X86_CR4_DE'? if (!(cr0 & X86_CR0_WP) && kvm_read_cr4_bits(vcpu, X86_CR4_CET)) ^~~~~~~~~~~ X86_CR4_DE arch/x86/kvm/x86.c:809:53: note: each undeclared identifier is reported only once for each function it appears in arch/x86/kvm/x86.c: At top level: >> arch/x86/kvm/x86.c:1233:16: error: 'MSR_IA32_U_CET' undeclared here (not in a function); did you mean 'MSR_IA32_TSC'? MSR_IA32_XSS, MSR_IA32_U_CET, MSR_IA32_S_CET, ^~~~~~~~~~~~~~ MSR_IA32_TSC >> arch/x86/kvm/x86.c:1233:32: error: 'MSR_IA32_S_CET' undeclared here (not in a function); did you mean 'MSR_IA32_U_CET'? MSR_IA32_XSS, MSR_IA32_U_CET, MSR_IA32_S_CET, ^~~~~~~~~~~~~~ MSR_IA32_U_CET >> arch/x86/kvm/x86.c:1234:2: error: 'MSR_IA32_PL0_SSP' undeclared here (not in a function); did you mean 'MSR_IA32_MCG_ESP'? MSR_IA32_PL0_SSP, MSR_IA32_PL1_SSP, MSR_IA32_PL2_SSP, ^~~~~~~~~~~~~~~~ MSR_IA32_MCG_ESP >> arch/x86/kvm/x86.c:1234:20: error: 'MSR_IA32_PL1_SSP' undeclared here (not in a function); did you mean 'MSR_IA32_PL0_SSP'? MSR_IA32_PL0_SSP, MSR_IA32_PL1_SSP, MSR_IA32_PL2_SSP, ^~~~~~~~~~~~~~~~ MSR_IA32_PL0_SSP >> arch/x86/kvm/x86.c:1234:38: error: 'MSR_IA32_PL2_SSP' undeclared here (not in a function); did you mean 'MSR_IA32_PL1_SSP'? MSR_IA32_PL0_SSP, MSR_IA32_PL1_SSP, MSR_IA32_PL2_SSP, ^~~~~~~~~~~~~~~~ MSR_IA32_PL1_SSP >> arch/x86/kvm/x86.c:1235:2: error: 'MSR_IA32_PL3_SSP' undeclared here (not in a function); did you mean 'MSR_IA32_PL2_SSP'? MSR_IA32_PL3_SSP, MSR_IA32_INT_SSP_TAB, ^~~~~~~~~~~~~~~~ MSR_IA32_PL2_SSP >> arch/x86/kvm/x86.c:1235:20: error: 'MSR_IA32_INT_SSP_TAB' undeclared here (not in a function); did you mean 'MSR_IA32_PL3_SSP'? MSR_IA32_PL3_SSP, MSR_IA32_INT_SSP_TAB, ^~~~~~~~~~~~~~~~~~~~ MSR_IA32_PL3_SSP arch/x86/kvm/x86.c: In function 'is_xsaves_msr': arch/x86/kvm/x86.c:3267:15: error: comparison between pointer and integer [-Werror] return index == MSR_IA32_U_CET || ^~ arch/x86/kvm/x86.c:3268:16: error: comparison between pointer and integer [-Werror] (index >= MSR_IA32_PL0_SSP && index <= MSR_IA32_PL3_SSP); ^~ arch/x86/kvm/x86.c:3268:45: error: comparison between pointer and integer [-Werror] (index >= MSR_IA32_PL0_SSP && index <= MSR_IA32_PL3_SSP); ^~ arch/x86/kvm/x86.c: In function 'kvm_arch_hardware_setup': arch/x86/kvm/x86.c:191:28: error: 'XFEATURE_MASK_CET_USER' undeclared (first use in this function); did you mean 'XFEATURE_MASK_BNDCSR'? #define KVM_SUPPORTED_XSS (XFEATURE_MASK_CET_USER | \ ^ arch/x86/kvm/x86.c:9678:30: note: in expansion of macro 'KVM_SUPPORTED_XSS' supported_xss = host_xss & KVM_SUPPORTED_XSS; ^~~~~~~~~~~~~~~~~ arch/x86/kvm/x86.c:192:6: error: 'XFEATURE_MASK_CET_KERNEL' undeclared (first use in this function); did you mean 'XFEATURE_MASK_CET_USER'? XFEATURE_MASK_CET_KERNEL) ^ arch/x86/kvm/x86.c:9678:30: note: in expansion of macro 'KVM_SUPPORTED_XSS' supported_xss = host_xss & KVM_SUPPORTED_XSS; ^~~~~~~~~~~~~~~~~ >> arch/x86/kvm/x86.c:191:51: error: invalid operands to binary | (have 'const u32 * {aka const unsigned int *}' and 'const u32 * {aka const unsigned int *}') #define KVM_SUPPORTED_XSS (XFEATURE_MASK_CET_USER | \ ~ ^ arch/x86/kvm/x86.c:9678:30: note: in expansion of macro 'KVM_SUPPORTED_XSS' supported_xss = host_xss & KVM_SUPPORTED_XSS; ^~~~~~~~~~~~~~~~~ >> arch/x86/kvm/x86.c:9678:28: error: invalid operands to binary & (have 'u64 {aka long long unsigned int}' and 'const u32 * {aka const unsigned int *}') supported_xss = host_xss & KVM_SUPPORTED_XSS; ^ >> arch/x86/kvm/x86.c:9678:17: error: assignment makes integer from pointer without a cast [-Werror=int-conversion] supported_xss = host_xss & KVM_SUPPORTED_XSS; ^ cc1: all warnings being treated as errors vim +1233 arch/x86/kvm/x86.c 1180 1181 /* 1182 * List of msr numbers which we expose to userspace through KVM_GET_MSRS 1183 * and KVM_SET_MSRS, and KVM_GET_MSR_INDEX_LIST. 1184 * 1185 * The three MSR lists(msrs_to_save, emulated_msrs, msr_based_features) 1186 * extract the supported MSRs from the related const lists. 1187 * msrs_to_save is selected from the msrs_to_save_all to reflect the 1188 * capabilities of the host cpu. This capabilities test skips MSRs that are 1189 * kvm-specific. Those are put in emulated_msrs_all; filtering of emulated_msrs 1190 * may depend on host virtualization features rather than host cpu features. 1191 */ 1192 1193 static const u32 msrs_to_save_all[] = { 1194 MSR_IA32_SYSENTER_CS, MSR_IA32_SYSENTER_ESP, MSR_IA32_SYSENTER_EIP, 1195 MSR_STAR, 1196 #ifdef CONFIG_X86_64 1197 MSR_CSTAR, MSR_KERNEL_GS_BASE, MSR_SYSCALL_MASK, MSR_LSTAR, 1198 #endif 1199 MSR_IA32_TSC, MSR_IA32_CR_PAT, MSR_VM_HSAVE_PA, 1200 MSR_IA32_FEAT_CTL, MSR_IA32_BNDCFGS, MSR_TSC_AUX, 1201 MSR_IA32_SPEC_CTRL, 1202 MSR_IA32_RTIT_CTL, MSR_IA32_RTIT_STATUS, MSR_IA32_RTIT_CR3_MATCH, 1203 MSR_IA32_RTIT_OUTPUT_BASE, MSR_IA32_RTIT_OUTPUT_MASK, 1204 MSR_IA32_RTIT_ADDR0_A, MSR_IA32_RTIT_ADDR0_B, 1205 MSR_IA32_RTIT_ADDR1_A, MSR_IA32_RTIT_ADDR1_B, 1206 MSR_IA32_RTIT_ADDR2_A, MSR_IA32_RTIT_ADDR2_B, 1207 MSR_IA32_RTIT_ADDR3_A, MSR_IA32_RTIT_ADDR3_B, 1208 MSR_IA32_UMWAIT_CONTROL, 1209 1210 MSR_ARCH_PERFMON_FIXED_CTR0, MSR_ARCH_PERFMON_FIXED_CTR1, 1211 MSR_ARCH_PERFMON_FIXED_CTR0 + 2, MSR_ARCH_PERFMON_FIXED_CTR0 + 3, 1212 MSR_CORE_PERF_FIXED_CTR_CTRL, MSR_CORE_PERF_GLOBAL_STATUS, 1213 MSR_CORE_PERF_GLOBAL_CTRL, MSR_CORE_PERF_GLOBAL_OVF_CTRL, 1214 MSR_ARCH_PERFMON_PERFCTR0, MSR_ARCH_PERFMON_PERFCTR1, 1215 MSR_ARCH_PERFMON_PERFCTR0 + 2, MSR_ARCH_PERFMON_PERFCTR0 + 3, 1216 MSR_ARCH_PERFMON_PERFCTR0 + 4, MSR_ARCH_PERFMON_PERFCTR0 + 5, 1217 MSR_ARCH_PERFMON_PERFCTR0 + 6, MSR_ARCH_PERFMON_PERFCTR0 + 7, 1218 MSR_ARCH_PERFMON_PERFCTR0 + 8, MSR_ARCH_PERFMON_PERFCTR0 + 9, 1219 MSR_ARCH_PERFMON_PERFCTR0 + 10, MSR_ARCH_PERFMON_PERFCTR0 + 11, 1220 MSR_ARCH_PERFMON_PERFCTR0 + 12, MSR_ARCH_PERFMON_PERFCTR0 + 13, 1221 MSR_ARCH_PERFMON_PERFCTR0 + 14, MSR_ARCH_PERFMON_PERFCTR0 + 15, 1222 MSR_ARCH_PERFMON_PERFCTR0 + 16, MSR_ARCH_PERFMON_PERFCTR0 + 17, 1223 MSR_ARCH_PERFMON_EVENTSEL0, MSR_ARCH_PERFMON_EVENTSEL1, 1224 MSR_ARCH_PERFMON_EVENTSEL0 + 2, MSR_ARCH_PERFMON_EVENTSEL0 + 3, 1225 MSR_ARCH_PERFMON_EVENTSEL0 + 4, MSR_ARCH_PERFMON_EVENTSEL0 + 5, 1226 MSR_ARCH_PERFMON_EVENTSEL0 + 6, MSR_ARCH_PERFMON_EVENTSEL0 + 7, 1227 MSR_ARCH_PERFMON_EVENTSEL0 + 8, MSR_ARCH_PERFMON_EVENTSEL0 + 9, 1228 MSR_ARCH_PERFMON_EVENTSEL0 + 10, MSR_ARCH_PERFMON_EVENTSEL0 + 11, 1229 MSR_ARCH_PERFMON_EVENTSEL0 + 12, MSR_ARCH_PERFMON_EVENTSEL0 + 13, 1230 MSR_ARCH_PERFMON_EVENTSEL0 + 14, MSR_ARCH_PERFMON_EVENTSEL0 + 15, 1231 MSR_ARCH_PERFMON_EVENTSEL0 + 16, MSR_ARCH_PERFMON_EVENTSEL0 + 17, 1232 > 1233 MSR_IA32_XSS, MSR_IA32_U_CET, MSR_IA32_S_CET, > 1234 MSR_IA32_PL0_SSP, MSR_IA32_PL1_SSP, MSR_IA32_PL2_SSP, > 1235 MSR_IA32_PL3_SSP, MSR_IA32_INT_SSP_TAB, 1236 }; 1237 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org