From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Dmitry Osipenko <digetx@gmail.com>,
Stefan Lengfeld <contact@stefanchrist.eu>,
Marco Felsch <m.felsch@pengutronix.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: at91: support atomic write xfer
Date: Sun, 22 Mar 2020 17:30:13 +0100 [thread overview]
Message-ID: <20200322163013.GA25488@qmqm.qmqm.pl> (raw)
In-Reply-To: <20200322143004.GB1091@ninjato>
On Sun, Mar 22, 2020 at 03:30:04PM +0100, Wolfram Sang wrote:
>
> > + /* FIXME: only single write request supported to 7-bit addr */
>
> Hmm, this is quite limited. Would it be very hard to support multiple
> messages? Or reads? 10 bits don't matter.
I don't expect this to be used for much more than a simple write to PMIC
to kill the power. So this patch is tailor made for exactly this purpose.
Though, if you would go for full support of atomic transfers, then
I would suggest to hack the non-atomic path to be usable in atomic mode
instead (some I2C drivers do just that, eg. i2c-tegra).
BTW, I found this comment in i2c-core.h:
* We only allow atomic transfers for very late communication, e.g. to send
* the powerdown command to a PMIC. Atomic transfers are a corner case and not
* for generic use!
I think this covers the idea.
> > + if (!dev->pdata->has_alt_cmd)
> > + return -EOPNOTSUPP;
>
> We should handle this in probe(), I think:
>
> if (dev->pdata->has_alt_cmd)
> at91_twi_algorithm.master_xfer_atomic = at91_twi_xfer_atomic;
This would mean writable ops structure - something I try hard to avoid.
We can use another copy of i2c_algorithm structure if needed, though.
Best Regards
Michał Mirosław
next prev parent reply other threads:[~2020-03-22 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-22 4:33 [PATCH v3] i2c: at91: support atomic write xfer Michał Mirosław
2020-03-22 14:30 ` Wolfram Sang
2020-03-22 16:30 ` Michał Mirosław [this message]
2020-05-05 15:52 ` Wolfram Sang
2020-05-05 16:47 ` Michał Mirosław
2020-05-06 17:17 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322163013.GA25488@qmqm.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=alexandre.belloni@bootlin.com \
--cc=contact@stefanchrist.eu \
--cc=digetx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=m.felsch@pengutronix.de \
--cc=nicolas.ferre@microchip.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).