* [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent
@ 2020-03-21 18:08 Keyur Patel
2020-03-22 21:16 ` Alexandre Belloni
0 siblings, 1 reply; 2+ messages in thread
From: Keyur Patel @ 2020-03-21 18:08 UTC (permalink / raw)
Cc: Keyur Patel, Alessandro Zummo, Alexandre Belloni, linux-rtc,
linux-kernel
Since the commit 7723f4c ("driver core: platform: Add an error message
to platform_get_irq*()") platform_get_irq() started issuing an error message.
Thus, there is no need to have the same in the driver.
Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
---
drivers/rtc/rtc-bd70528.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/rtc/rtc-bd70528.c b/drivers/rtc/rtc-bd70528.c
index bbbb1f07c91f..4492b770422c 100644
--- a/drivers/rtc/rtc-bd70528.c
+++ b/drivers/rtc/rtc-bd70528.c
@@ -542,10 +542,8 @@ static int bd70528_probe(struct platform_device *pdev)
irq = platform_get_irq_byname(pdev, irq_name);
- if (irq < 0) {
- dev_err(&pdev->dev, "Failed to get irq\n");
+ if (irq < 0)
return irq;
- }
platform_set_drvdata(pdev, bd_rtc);
--
2.25.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent
2020-03-21 18:08 [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent Keyur Patel
@ 2020-03-22 21:16 ` Alexandre Belloni
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Belloni @ 2020-03-22 21:16 UTC (permalink / raw)
To: Keyur Patel; +Cc: Alessandro Zummo, linux-rtc, linux-kernel
On 21/03/2020 14:08:37-0400, Keyur Patel wrote:
> Since the commit 7723f4c ("driver core: platform: Add an error message
> to platform_get_irq*()") platform_get_irq() started issuing an error message.
> Thus, there is no need to have the same in the driver.
>
> Signed-off-by: Keyur Patel <iamkeyur96@gmail.com>
> ---
> drivers/rtc/rtc-bd70528.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-03-22 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-21 18:08 [PATCH] rtc: bd70528: Avoid double error messaging when IRQ absent Keyur Patel
2020-03-22 21:16 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).