From: "andriy.shevchenko@intel.com" <andriy.shevchenko@intel.com>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "Tachici, Alexandru" <Alexandru.Tachici@analog.com>,
"jic23@kernel.org" <jic23@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"Caprioru, Mircea" <Mircea.Caprioru@analog.com>
Subject: Re: [PATCH v4 1/2] iio: dac: ad5770r: Add AD5770R support
Date: Mon, 23 Mar 2020 00:19:13 +0200 [thread overview]
Message-ID: <20200322221913.GA1922688@smile.fi.intel.com> (raw)
In-Reply-To: <2942e900ab01957027b918b2a5fdbd665fe6b2ed.camel@analog.com>
On Sun, Mar 22, 2020 at 09:17:06AM +0000, Ardelean, Alexandru wrote:
> On Sat, 2020-03-21 at 23:09 +0200, Andy Shevchenko wrote:
> > On Tue, Feb 18, 2020 at 02:10:30PM +0200, Alexandru Tachici wrote:
> > > The AD5770R is a 6-channel, 14-bit resolution, low noise, programmable
> > > current output digital-to-analog converter (DAC) for photonics control
> > > applications.
> > >
> > > It contains five 14-bit resolution current sourcing DAC channels and one
> > > 14-bit resolution current sourcing/sinking DAC channel.
> >
>
> This patch made it into linux-next.
> Doing a v2 now may be a bit noisy.
>
> Maybe we can tidy-this-up later.
> To be honest, it won't be the highest on our list.
> [ I know how that sounds ]
Yes, you may consider a follow up.
> We can probably leave it for other people to clean it up.
> [ People that want to start contributing to the kernel ]
Maybe, but isn't better to supply cleaner code in the first place?
I mean that these comments may be taken into consideration for the future
contributions.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-22 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 12:10 [PATCH v4 0/2] iio: dac: AD5770R: Add support Alexandru Tachici
2020-02-18 12:10 ` [PATCH v4 1/2] iio: dac: ad5770r: Add AD5770R support Alexandru Tachici
2020-02-21 15:05 ` Jonathan Cameron
2020-03-21 21:09 ` Andy Shevchenko
2020-03-22 9:17 ` Ardelean, Alexandru
2020-03-22 22:19 ` andriy.shevchenko [this message]
2020-02-18 12:10 ` [PATCH v4 2/2] dt-bindings: iio: dac: Add docs for AD5770R DAC Alexandru Tachici
2020-02-21 15:07 ` Jonathan Cameron
2020-03-20 0:49 ` Rob Herring
2020-03-21 10:38 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200322221913.GA1922688@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Alexandru.Tachici@analog.com \
--cc=Mircea.Caprioru@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).