From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0133C54FCE for ; Mon, 23 Mar 2020 03:32:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC6CD20724 for ; Mon, 23 Mar 2020 03:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584934355; bh=mKhFScqksiFKsGX5adSdphlfjuvv2FRVmg9JYk1ha3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NhhQdq6+swr69f52kpJdM9rTdQ5NIU3CgBNxfr2OdbACXaiAXUoxizrknpXrZm9JD 9mloHxWyIPHrx1bhcCHwJ3yoD6H6uAW2KURZ4K6xEz2qaQKrpualulUWjbheouyUoW 4uDJGEUFB22sT7VlhwmlayfuPpMY9rwLJL6c/wXo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727241AbgCWDc0 (ORCPT ); Sun, 22 Mar 2020 23:32:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:42492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727186AbgCWDcZ (ORCPT ); Sun, 22 Mar 2020 23:32:25 -0400 Received: from lenoir.home (lfbn-ncy-1-985-231.w90-101.abo.wanadoo.fr [90.101.63.231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 58EF820777; Mon, 23 Mar 2020 03:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584934344; bh=mKhFScqksiFKsGX5adSdphlfjuvv2FRVmg9JYk1ha3I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=szcB9L4R+X8ff+n3HayaS4HZkFOeX2xt5uiRy3mAwxNTUZ1xkAgQKj/uzqifUEvvz 0QtrFW/uZC/SF8KQ5+O38UX4qHjMHEvUs5f5Z256TTIqDoBFFWGLI96xAnTy4ZEgo6 UkZFz6UB3yx5+uooSF8IpjSDSdl9HL+kQtsLmrsQ= From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Sebastian Andrzej Siewior , Peter Zijlstra , "Paul E . McKenney" , Thomas Gleixner Subject: [RFC PATCH 3/3] lockdep: Briefly comment current->hardirq_threadable usecases Date: Mon, 23 Mar 2020 04:32:07 +0100 Message-Id: <20200323033207.32370-4-frederic@kernel.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200323033207.32370-1-frederic@kernel.org> References: <20200323033207.32370-1-frederic@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We have yet to find a proper comment for rcu_iw_handler() though. Signed-off-by: Frederic Weisbecker Cc: Thomas Gleixner Cc: Peter Zijlstra Cc: Sebastian Andrzej Siewior Cc: Paul E. McKenney --- kernel/time/posix-cpu-timers.c | 1 + kernel/time/tick-sched.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c index d29a06d60206..85902d756e21 100644 --- a/kernel/time/posix-cpu-timers.c +++ b/kernel/time/posix-cpu-timers.c @@ -1126,6 +1126,7 @@ void run_posix_cpu_timers(void) if (!fastpath_timer_check(tsk)) return; + /* Should be offloaded to task_work at some future */ trace_hardirq_threadable(); if (!lock_task_sighand(tsk, &flags)) { trace_hardirq_unthreadable(); diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 3e2dc9b8858c..d469972673e4 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -245,6 +245,10 @@ static void nohz_full_kick_func(struct irq_work *work) static DEFINE_PER_CPU(struct irq_work, nohz_full_kick_work) = { .func = nohz_full_kick_func, + /* + * Must stay in hardirq. Threading would mess up with tick + * dependencies. + */ .flags = ATOMIC_INIT(IRQ_WORK_HARD_IRQ), }; -- 2.25.0