From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90573C54FCE for ; Mon, 23 Mar 2020 15:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 684922072E for ; Mon, 23 Mar 2020 15:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XURddeuh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727296AbgCWPOb (ORCPT ); Mon, 23 Mar 2020 11:14:31 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:52098 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbgCWPOb (ORCPT ); Mon, 23 Mar 2020 11:14:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1m+OiC3y42SS9da+Tcx1VksIIwVDt7LFueQm6zuxGVo=; b=XURddeuh+RoTABs816IckUXkfW egzgUGPHZht3RdSInSrJYSrt7X9WDAhCHamL4zw3CVNk1yNkmg8mPClDl87yQBxh1ptYvfaoEDUbw Axs5liIRIXS3Nl3+tBfKHmEpVjiBJ/o8J0AiUUjo1zF+QiGToIJBQ4ZHZi7to6N0iFXI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.93) (envelope-from ) id 1jGOmV-0000ni-Na; Mon, 23 Mar 2020 16:14:23 +0100 Date: Mon, 23 Mar 2020 16:14:23 +0100 From: Andrew Lunn To: Christian Herber Cc: Rob Herring , Florian Fainelli , Oleksij Rempel , Mark Rutland , "devicetree@vger.kernel.org" , Marek Vasut , netdev , "linux-kernel@vger.kernel.org" , Pengutronix Kernel Team , David Jander , "David S. Miller" , Heiner Kallweit Subject: Re: Re: [PATCH v4 1/4] dt-bindings: net: phy: Add support for NXP TJA11xx Message-ID: <20200323151423.GA32387@lunn.ch> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Yes, it is one device with two address. This is if you call the entire IC a device. If you look at it from a PHY perspective, it is two devices with 1 address. > If you just look at it as a single device, it gets difficult to add PHY specific properties in the future, e.g. master/slave selection. > In my opinion its important to have some kind of container for the > entire IC, but likewise for the individual PHYs. Yes, we need some sort of representation of two devices. Logically, the two PHYs are on the same MDIO bus, so you could have two nodes on the main bus. Or you consider the secondary PHY as being on an internal MDIO bus which is transparently bridged to the main bus. This is what was proposed in the last patchset. Because this bridge is transparent, the rest of the PHY/MDIO framework has no idea about it. So i prefer that we keep with two PHY nodes on the main bus. But i still think we need the master PHY to register the secondary PHY, due to the missing PHY ID, and the other constrains like resets which the master PHY has to handle. Andrew