From: Qais Yousef <qais.yousef@arm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oneukum@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: lockdep warning in urb.c:363 usb_submit_urb
Date: Mon, 23 Mar 2020 16:02:28 +0000 [thread overview]
Message-ID: <20200323160228.x3sqz64qdx6wenpo@e107158-lin.cambridge.arm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.2003231151390.24254-100000@netrider.rowland.org>
On 03/23/20 11:54, Alan Stern wrote:
> On Mon, 23 Mar 2020, Oliver Neukum wrote:
>
> > Am Montag, den 23.03.2020, 14:38 +0000 schrieb Qais Yousef:
> > > Hi
> > >
> > > I've hit the following lockdep warning when I trigger hibernate on arm64
> > > platform (Juno-r2)
> > >
> > >
> > > echo suspend > /sys/power/disk
> > > echo disk > /sys/power/state
> > >
> > > I only had a usb flash drive attached to it. Let me know if you need more info.
> >
> > Hi,
> >
> > that is not a lockdep issue, but the hub driver is not properly killing
> > its URB presumably. Yet, the driver looks correct to me. Please use
> > the additional patch and activate dynamic debugging for usbcore.
>
> Was the USB flash drive being used as a swap device for holding the
> hibernation image? That's not likely to work very well. At least, I
> doubt that it has been tested very much.
>
> This diagnostic was suggested by the runtime PM error that occurred
> when the system was trying to store the hibernation image. That's
> probably when the hub driver's URB got restarted.
Yes, sadly it's the only source of storage I have on that device.
When I ran the test I had swapoff, as you can see in the snippet below. When
swap is on I do hibernate and wakeup successfully. At least that's what appears
to be happening to me.
I get a similar splat regardless of swap is on or off.
[ 327.154849] usb usb2: runtime PM trying to activate child device usb2 but parent (7ffb0000.ohci) is not active
[ 327.290355] PM: Cannot find swap device, try swapon -a
[ 327.295533] PM: Cannot get swap writer
[ 327.480758] OOM killer enabled.
[ 327.483939] Restarting tasks ...
[ 327.484229] ------------[ cut here ]------------
[ 327.484664] done.
[ 327.487743] URB 000000000c121c1c submitted while active
[ 327.499622] WARNING: CPU: 1 PID: 296 at drivers/usb/core/urb.c:363 usb_submit_urb+0x3f0/0x520
Thanks
--
Qais Yousef
next prev parent reply other threads:[~2020-03-23 16:02 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:38 lockdep warning in urb.c:363 usb_submit_urb Qais Yousef
2020-03-23 15:36 ` Oliver Neukum
2020-03-23 15:54 ` Alan Stern
2020-03-23 16:02 ` Qais Yousef [this message]
2020-03-23 16:18 ` Oliver Neukum
2020-03-23 15:57 ` Qais Yousef
2020-03-23 16:20 ` Oliver Neukum
2020-03-23 17:29 ` Qais Yousef
2020-03-24 9:08 ` Oliver Neukum
2020-03-24 10:46 ` Qais Yousef
2020-03-24 13:20 ` Oliver Neukum
2020-03-24 13:43 ` Qais Yousef
2020-03-24 13:52 ` Alan Stern
2020-03-24 14:06 ` Qais Yousef
2020-03-24 15:56 ` Alan Stern
2020-03-24 17:22 ` Qais Yousef
2020-03-24 19:22 ` Alan Stern
2020-03-25 15:00 ` Qais Yousef
2020-03-25 20:49 ` Alan Stern
2020-03-25 21:28 ` Rafael J. Wysocki
2020-03-26 12:27 ` Qais Yousef
2020-03-27 20:45 ` Alan Stern
2020-03-28 14:15 ` Rafael J. Wysocki
2020-03-28 19:58 ` Alan Stern
2020-03-29 9:16 ` Rafael J. Wysocki
2020-03-29 13:56 ` Rafael J. Wysocki
2020-03-29 16:27 ` Alan Stern
2020-04-03 15:04 ` Rafael J. Wysocki
2020-04-03 16:13 ` Rafael J. Wysocki
2020-04-03 16:41 ` Alan Stern
2020-04-03 18:32 ` Rafael J. Wysocki
2020-04-03 20:15 ` Alan Stern
2020-04-06 16:45 ` Rafael J. Wysocki
2020-04-06 20:25 ` Alan Stern
2020-04-09 18:45 ` Rafael J. Wysocki
2020-04-11 2:41 ` Alan Stern
2020-04-13 21:32 ` Rafael J. Wysocki
2020-04-14 13:43 ` Rafael J. Wysocki
2020-04-14 17:47 ` Alan Stern
2020-04-15 22:20 ` Rafael J. Wysocki
2020-04-16 15:18 ` Alan Stern
2020-04-17 9:57 ` Rafael J. Wysocki
2020-04-17 16:10 ` Alan Stern
2020-04-17 21:54 ` Rafael J. Wysocki
2020-04-17 23:37 ` Alan Stern
2020-04-18 9:40 ` Rafael J. Wysocki
2020-04-03 17:08 ` Rafael J. Wysocki
2020-04-20 20:26 ` Alan Stern
2020-04-21 11:15 ` Qais Yousef
2020-03-24 13:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323160228.x3sqz64qdx6wenpo@e107158-lin.cambridge.arm.com \
--to=qais.yousef@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).