From: Peter Xu <peterx@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
"Michael S . Tsirkin" <mst@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Yan Zhao <yan.y.zhao@intel.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Christophe de Dinechin <dinechin@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Kevin Tian <kevin.tian@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v7 06/14] KVM: Make dirty ring exclusive to dirty bitmap log
Date: Mon, 23 Mar 2020 12:16:26 -0400 [thread overview]
Message-ID: <20200323161626.GJ127076@xz-x1> (raw)
In-Reply-To: <20200321191250.GB13851@linux.intel.com>
On Sat, Mar 21, 2020 at 12:12:50PM -0700, Sean Christopherson wrote:
> On Wed, Mar 18, 2020 at 12:37:12PM -0400, Peter Xu wrote:
> > There's no good reason to use both the dirty bitmap logging and the
> > new dirty ring buffer to track dirty bits. We should be able to even
> > support both of them at the same time, but it could complicate things
> > which could actually help little. Let's simply make it the rule
> > before we enable dirty ring on any arch, that we don't allow these two
> > interfaces to be used together.
> >
> > The big world switch would be KVM_CAP_DIRTY_LOG_RING capability
> > enablement. That's where we'll switch from the default dirty logging
> > way to the dirty ring way. As long as kvm->dirty_ring_size is setup
> > correctly, we'll once and for all switch to the dirty ring buffer mode
> > for the current virtual machine.
> >
> > Signed-off-by: Peter Xu <peterx@redhat.com>
> > ---
> > Documentation/virt/kvm/api.rst | 7 +++++++
> > virt/kvm/kvm_main.c | 12 ++++++++++++
> > 2 files changed, 19 insertions(+)
> >
> > diff --git a/Documentation/virt/kvm/api.rst b/Documentation/virt/kvm/api.rst
> > index 99ee9cfc20c4..8f3a83298d3f 100644
> > --- a/Documentation/virt/kvm/api.rst
> > +++ b/Documentation/virt/kvm/api.rst
> > @@ -6202,3 +6202,10 @@ make sure all the existing dirty gfns are flushed to the dirty rings.
> >
> > The dirty ring can gets full. When it happens, the KVM_RUN of the
> > vcpu will return with exit reason KVM_EXIT_DIRTY_LOG_FULL.
> > +
> > +NOTE: the KVM_CAP_DIRTY_LOG_RING capability and the new ioctl
>
> Leave off "new", it'll be stale a few months/years from now.
Ok.
>
> > +KVM_RESET_DIRTY_RINGS are exclusive to the existing KVM_GET_DIRTY_LOG
>
> Did you mean "mutually exclusive with"? "exclusive to" would mean they
> can only be used by KVM_GET_DIRTY_LOG with doesn't match the next
> sentence.
I meant "mutual-exclusive". I'll fix it up.
Thanks,
--
Peter Xu
next prev parent reply other threads:[~2020-03-23 16:16 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 16:37 [PATCH v7 00/14] KVM: Dirty ring interface Peter Xu
2020-03-18 16:37 ` [PATCH v7 01/14] KVM: X86: Change parameter for fast_page_fault tracepoint Peter Xu
2020-03-18 16:37 ` [PATCH v7 02/14] KVM: Cache as_id in kvm_memory_slot Peter Xu
2020-03-18 16:37 ` [PATCH v7 03/14] KVM: X86: Don't track dirty for KVM_SET_[TSS_ADDR|IDENTITY_MAP_ADDR] Peter Xu
2020-03-21 19:22 ` Sean Christopherson
2020-03-23 14:58 ` Peter Xu
2020-03-23 15:42 ` Sean Christopherson
2020-03-23 16:26 ` Peter Xu
2020-03-23 16:55 ` Sean Christopherson
2020-03-23 17:13 ` Peter Xu
2020-03-18 16:37 ` [PATCH v7 04/14] KVM: Pass in kvm pointer into mark_page_dirty_in_slot() Peter Xu
2020-03-18 16:37 ` [PATCH v7 05/14] KVM: X86: Implement ring-based dirty memory tracking Peter Xu
2020-03-18 16:37 ` [PATCH v7 06/14] KVM: Make dirty ring exclusive to dirty bitmap log Peter Xu
2020-03-21 19:12 ` Sean Christopherson
2020-03-23 16:16 ` Peter Xu [this message]
2020-03-18 16:37 ` [PATCH v7 07/14] KVM: Don't allocate dirty bitmap if dirty ring is enabled Peter Xu
2020-03-18 16:37 ` [PATCH v7 08/14] KVM: selftests: Always clear dirty bitmap after iteration Peter Xu
2020-03-18 16:37 ` [PATCH v7 09/14] KVM: selftests: Sync uapi/linux/kvm.h to tools/ Peter Xu
2020-03-18 16:37 ` [PATCH v7 10/14] KVM: selftests: Use a single binary for dirty/clear log test Peter Xu
2020-03-19 7:44 ` Andrew Jones
2020-03-18 16:37 ` [PATCH v7 11/14] KVM: selftests: Introduce after_vcpu_run hook for dirty " Peter Xu
2020-03-19 7:50 ` Andrew Jones
2020-03-19 16:37 ` Peter Xu
2020-03-18 16:37 ` [PATCH v7 12/14] KVM: selftests: Add dirty ring buffer test Peter Xu
2020-03-19 17:02 ` Peter Xu
2020-03-18 16:37 ` [PATCH v7 13/14] KVM: selftests: Let dirty_log_test async for dirty ring test Peter Xu
2020-03-18 16:37 ` [PATCH v7 14/14] KVM: selftests: Add "-c" parameter to dirty log test Peter Xu
2020-03-19 7:54 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323161626.GJ127076@xz-x1 \
--to=peterx@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=dgilbert@redhat.com \
--cc=dinechin@redhat.com \
--cc=jasowang@redhat.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=vkuznets@redhat.com \
--cc=yan.y.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).