From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FFCC4332B for ; Tue, 24 Mar 2020 10:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA92120870 for ; Tue, 24 Mar 2020 10:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RKCe9AqJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727289AbgCXKdG (ORCPT ); Tue, 24 Mar 2020 06:33:06 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:43682 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727112AbgCXKdF (ORCPT ); Tue, 24 Mar 2020 06:33:05 -0400 Received: by mail-wr1-f65.google.com with SMTP id b2so20698418wrj.10 for ; Tue, 24 Mar 2020 03:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=IrXGZHQOvRbVrdhyf/YbRhdpgB7gnLqs/mPRG5sDLy8=; b=RKCe9AqJsuMkR/lMvYJWSWdCJnc1DPMPpVeLHXBVb+QXi4dQYkPD+C/kF0fBm3IHMF WEt7EA8eWrnGZDE+025B+xvia3MieEBNPFwUPFuJSKS7A//eicws5oy4X4T8tqm11l05 94eqTdiVFrR/HvNYYACXO3bLpi2UUTnj9M6fnwIWBuyn7BuxOgfRgiNRy2F/pUKfutyw /TzVrgmhXXMqkodvQ1gkSAyO9biPMerMgQwY5O6NnNRjxpn+t18puUb8vLX5k3gwoPM4 PiSrnmaRu3kOGD+2VEZjV6L1wYvs7tfOvs/mF0WanLBpv3BTNWjfKrTiLRieE0IMqoC0 T9uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=IrXGZHQOvRbVrdhyf/YbRhdpgB7gnLqs/mPRG5sDLy8=; b=LPGhU2AuOSrigB1GQRbOJXRks1h0u6iz/2RFKk+hfK2jTpr/okHJV0lOSdd2F5PMDo aVoRQ53dGERaegR9RMbmnEMx/IT0hJQPpUxMLPct3DpTIOLUWKhpF0OK9aWz3WfnqcsJ hPL6ajH1LCV4LemZZhLhtipoVWl6KWcCDEKjF1a3qZvlUL7hWNJjSFuZBWAQVAOuu38o K/QR+s+JkeLqtsKyKzx455cu29j2kwr5VgvrUoiivQ/Eo0NmEY09LoHtrt8CdrFmiOBw O6JizGDtavf6pGl++Perfmm/5dklwSHjFzKbe0QktGPcyLkvB847B9yOD8WHs/nCFWpj IPGw== X-Gm-Message-State: ANhLgQ1AsidGJtShLjHnc0ep087902XeFmYmPsMAJpuyaABJFz6Wo6gH NF1dMlSBLAOO7zymVI75b9fbPw== X-Google-Smtp-Source: ADFU+vtHp9ysDVVXPgqTHTn9l98ma/U7CpdYITGz7jbimYm+l7hrGG3ySHDK1cpVtfXjt18py39TrA== X-Received: by 2002:adf:de01:: with SMTP id b1mr10143860wrm.376.1585045984218; Tue, 24 Mar 2020 03:33:04 -0700 (PDT) Received: from dell ([2.27.35.213]) by smtp.gmail.com with ESMTPSA id o26sm3564319wmc.33.2020.03.24.03.33.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 03:33:03 -0700 (PDT) Date: Tue, 24 Mar 2020 10:33:52 +0000 From: Lee Jones To: Andreas Kemnade Cc: robh+dt@kernel.org, mark.rutland@arm.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, stefan@agner.ch, b.galvani@gmail.com, phh@phh.me, letux-kernel@openphoenux.org, knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, jic23@kernel.org Subject: Re: [PATCH v7 2/7] mfd: rn5t618: add IRQ support Message-ID: <20200324103352.GH5477@dell> References: <20200320081105.12026-1-andreas@kemnade.info> <20200320081105.12026-3-andreas@kemnade.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200320081105.12026-3-andreas@kemnade.info> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Mar 2020, Andreas Kemnade wrote: > This adds support for IRQ handling in the RC5T619 which is required > for properly implementing subdevices like RTC. > For now only definitions for the variant RC5T619 are included. > > Signed-off-by: Andreas Kemnade > --- > Changes in v7: > more cleanups in IRQ init > > Changes in v5: > rn5t618_irq_init static > > Changes in v4: > merge rn5t618-irq.c into rn5t618.c > use macros for IRQ table > > Changes in v3: > alignment cleanup > > Changes in v2: > - no dead code, did some more testing and thinking for that > - remove extra empty lines > drivers/mfd/Kconfig | 1 + > drivers/mfd/rn5t618.c | 78 ++++++++++++++++++++++++++++++++++++- > include/linux/mfd/rn5t618.h | 15 +++++++ > 3 files changed, 93 insertions(+), 1 deletion(-) Looks good to me now: For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog