From: Qais Yousef <qais.yousef@arm.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oneukum@suse.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: lockdep warning in urb.c:363 usb_submit_urb
Date: Tue, 24 Mar 2020 17:22:36 +0000 [thread overview]
Message-ID: <20200324172235.bsxea6qb3id6bhb3@e107158-lin> (raw)
In-Reply-To: <Pine.LNX.4.44L0.2003241137440.16735-100000@netrider.rowland.org>
On 03/24/20 11:56, Alan Stern wrote:
> On Tue, 24 Mar 2020, Qais Yousef wrote:
>
> > On 03/24/20 09:52, Alan Stern wrote:
> > > On Tue, 24 Mar 2020, Qais Yousef wrote:
> > >
> > > > On 03/24/20 14:20, Oliver Neukum wrote:
> > > > > Am Dienstag, den 24.03.2020, 10:46 +0000 schrieb Qais Yousef:
> > > > > >
> > > > > > I should have stuck to what I know then. I misread the documentation. Hopefully
> > > > > > the attached looks better. I don't see the new debug you added emitted.
> > > > >
> > > > > That is odd. Please try
> > > > >
> > > > > echo "module usbcore +mfp" > /sys/kernel/debug/dynamic_debug/control
> > > > >
> > > > > with the attached improved patch.
> > > >
> > > > Hmm still no luck
> > > >
> > > >
> > > > # history
> > > > 0 echo "module usbcore +mfp" > /sys/kernel/debug/dynamic_debug/control
> > > > 1 swapoff -a
> > > > 2 echo suspend > /sys/power/disk
> > > > 3 echo disk > /sys/power/state
> > > > 4 dmesg > usb.dmesg
> > >
> > > What happens if you omit step 1 (the swapoff)?
> >
> > It seems to hibernate (suspend) successfully. If I omit that step I must setup
> > a wakealarm to trigger the wakeup, but that's it.
>
> You don't have any other wakeup sources? Like a power button?
Not sure if it's hooked correctly as a wakeup source. But as UK is now getting
lockedown, I don't think I'll be seeing the board for a while and serial
console is my only friend :-)
I can hard reboot remotely reliably though.
>
> > I attached the dmesg; I didn't reboot the system in between.
> >
> >
> > # history
> > 0 echo "module usbcore +mfp" > /sys/kernel/debug/dynamic_debug/control
> > 1 swapoff -a
> > 2 echo suspend > /sys/power/disk
> > 3 echo disk > /sys/power/state
> > 4 dmesg > usb.dmesg
> > 5 history
> > 6 grep URB /sys/kernel/debug/dynamic_debug/control
> > 7 grep "URB allocated" /sys/kernel/debug/dynamic_debug/control
> > 8 swapon -a
> > 9 echo +60 > /sys/class/rtc/rtc0/wakealarm
> > 10 echo disk > /sys/power/state
> > 11 dmesg > usb.dmesg
>
> This certainly reinforces the initial impression that the cause of the
> warnings is a bug in the platform code. You should ask the appropriate
> maintainer.
The device-tree compatible node returns "generic-ohci".
drivers/usb/host/ohci-platform.c returns you as the maintainer :-)
>
> However, an equally troubling question is why the usb2 bus never got
> suspended in the first place. To solve that, you may need to enable
> dynamic debugging in the Power Management core (i.e., "file
> drivers/base/power/* +p").
Thanks Alan. I'll run with extra debug and send back.
Cheers
--
Qais Yousef
next prev parent reply other threads:[~2020-03-24 17:22 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 14:38 lockdep warning in urb.c:363 usb_submit_urb Qais Yousef
2020-03-23 15:36 ` Oliver Neukum
2020-03-23 15:54 ` Alan Stern
2020-03-23 16:02 ` Qais Yousef
2020-03-23 16:18 ` Oliver Neukum
2020-03-23 15:57 ` Qais Yousef
2020-03-23 16:20 ` Oliver Neukum
2020-03-23 17:29 ` Qais Yousef
2020-03-24 9:08 ` Oliver Neukum
2020-03-24 10:46 ` Qais Yousef
2020-03-24 13:20 ` Oliver Neukum
2020-03-24 13:43 ` Qais Yousef
2020-03-24 13:52 ` Alan Stern
2020-03-24 14:06 ` Qais Yousef
2020-03-24 15:56 ` Alan Stern
2020-03-24 17:22 ` Qais Yousef [this message]
2020-03-24 19:22 ` Alan Stern
2020-03-25 15:00 ` Qais Yousef
2020-03-25 20:49 ` Alan Stern
2020-03-25 21:28 ` Rafael J. Wysocki
2020-03-26 12:27 ` Qais Yousef
2020-03-27 20:45 ` Alan Stern
2020-03-28 14:15 ` Rafael J. Wysocki
2020-03-28 19:58 ` Alan Stern
2020-03-29 9:16 ` Rafael J. Wysocki
2020-03-29 13:56 ` Rafael J. Wysocki
2020-03-29 16:27 ` Alan Stern
2020-04-03 15:04 ` Rafael J. Wysocki
2020-04-03 16:13 ` Rafael J. Wysocki
2020-04-03 16:41 ` Alan Stern
2020-04-03 18:32 ` Rafael J. Wysocki
2020-04-03 20:15 ` Alan Stern
2020-04-06 16:45 ` Rafael J. Wysocki
2020-04-06 20:25 ` Alan Stern
2020-04-09 18:45 ` Rafael J. Wysocki
2020-04-11 2:41 ` Alan Stern
2020-04-13 21:32 ` Rafael J. Wysocki
2020-04-14 13:43 ` Rafael J. Wysocki
2020-04-14 17:47 ` Alan Stern
2020-04-15 22:20 ` Rafael J. Wysocki
2020-04-16 15:18 ` Alan Stern
2020-04-17 9:57 ` Rafael J. Wysocki
2020-04-17 16:10 ` Alan Stern
2020-04-17 21:54 ` Rafael J. Wysocki
2020-04-17 23:37 ` Alan Stern
2020-04-18 9:40 ` Rafael J. Wysocki
2020-04-03 17:08 ` Rafael J. Wysocki
2020-04-20 20:26 ` Alan Stern
2020-04-21 11:15 ` Qais Yousef
2020-03-24 13:47 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200324172235.bsxea6qb3id6bhb3@e107158-lin \
--to=qais.yousef@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).