Re: [v1,net-next 5/5] net: enetc: add tc flower psfp offload driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5660 bytes --]

Hi Po,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200323]
[cannot apply to linux/master linus/master sparc-next/master ipvs/master v5.6-rc7 v5.6-rc6 v5.6-rc5 v5.6-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Po-Liu/Introduce-a-flow-gate-control-action-and-apply-IEEE/20200324-121156
base:    5149100c3aebe5e640d6ff68e0b5e5a7eb8638e0
config: arm64-defconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=9.2.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/net/ethernet/freescale/enetc/enetc_pf.c: In function 'enetc_pf_netdev_setup':
>> drivers/net/ethernet/freescale/enetc/enetc_pf.c:743:62: error: passing argument 1 of 'enetc_psfp_enable' from incompatible pointer type [-Werror=incompatible-pointer-types]
     743 |  if (si->hw_features & ENETC_SI_F_PSFP && !enetc_psfp_enable(priv)) {
         |                                                              ^~~~
         |                                                              |
         |                                                              struct enetc_ndev_priv *
   In file included from drivers/net/ethernet/freescale/enetc/enetc_pf.h:4,
                    from drivers/net/ethernet/freescale/enetc/enetc_pf.c:8:
   drivers/net/ethernet/freescale/enetc/enetc.h:374:54: note: expected 'struct enetc_hw *' but argument is of type 'struct enetc_ndev_priv *'
     374 | static inline int enetc_psfp_enable(struct enetc_hw *hw)
         |                                     ~~~~~~~~~~~~~~~~~^~
   cc1: some warnings being treated as errors
--
   drivers/net/ethernet/freescale/enetc/enetc.c: In function 'enetc_set_psfp':
>> drivers/net/ethernet/freescale/enetc/enetc.c:1581:27: error: passing argument 1 of 'enetc_psfp_enable' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1581 |   err = enetc_psfp_enable(priv);
         |                           ^~~~
         |                           |
         |                           struct enetc_ndev_priv *
   In file included from drivers/net/ethernet/freescale/enetc/enetc.c:4:
   drivers/net/ethernet/freescale/enetc/enetc.h:374:54: note: expected 'struct enetc_hw *' but argument is of type 'struct enetc_ndev_priv *'
     374 | static inline int enetc_psfp_enable(struct enetc_hw *hw)
         |                                     ~~~~~~~~~~~~~~~~~^~
>> drivers/net/ethernet/freescale/enetc/enetc.c:1589:27: error: passing argument 1 of 'enetc_psfp_disable' from incompatible pointer type [-Werror=incompatible-pointer-types]
    1589 |  err = enetc_psfp_disable(priv);
         |                           ^~~~
         |                           |
         |                           struct enetc_ndev_priv *
   In file included from drivers/net/ethernet/freescale/enetc/enetc.c:4:
   drivers/net/ethernet/freescale/enetc/enetc.h:379:55: note: expected 'struct enetc_hw *' but argument is of type 'struct enetc_ndev_priv *'
     379 | static inline int enetc_psfp_disable(struct enetc_hw *hw)
         |                                      ~~~~~~~~~~~~~~~~~^~
   cc1: some warnings being treated as errors

vim +/enetc_psfp_enable +743 drivers/net/ethernet/freescale/enetc/enetc_pf.c

   703	
   704	static void enetc_pf_netdev_setup(struct enetc_si *si, struct net_device *ndev,
   705					  const struct net_device_ops *ndev_ops)
   706	{
   707		struct enetc_ndev_priv *priv = netdev_priv(ndev);
   708	
   709		SET_NETDEV_DEV(ndev, &si->pdev->dev);
   710		priv->ndev = ndev;
   711		priv->si = si;
   712		priv->dev = &si->pdev->dev;
   713		si->ndev = ndev;
   714	
   715		priv->msg_enable = (NETIF_MSG_WOL << 1) - 1;
   716		ndev->netdev_ops = ndev_ops;
   717		enetc_set_ethtool_ops(ndev);
   718		ndev->watchdog_timeo = 5 * HZ;
   719		ndev->max_mtu = ENETC_MAX_MTU;
   720	
   721		ndev->hw_features = NETIF_F_SG | NETIF_F_RXCSUM | NETIF_F_HW_CSUM |
   722				    NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX |
   723				    NETIF_F_LOOPBACK;
   724		ndev->features = NETIF_F_HIGHDMA | NETIF_F_SG |
   725				 NETIF_F_RXCSUM | NETIF_F_HW_CSUM |
   726				 NETIF_F_HW_VLAN_CTAG_TX |
   727				 NETIF_F_HW_VLAN_CTAG_RX |
   728				 NETIF_F_HW_VLAN_CTAG_FILTER;
   729	
   730		if (si->num_rss)
   731			ndev->hw_features |= NETIF_F_RXHASH;
   732	
   733		if (si->errata & ENETC_ERR_TXCSUM) {
   734			ndev->hw_features &= ~NETIF_F_HW_CSUM;
   735			ndev->features &= ~NETIF_F_HW_CSUM;
   736		}
   737	
   738		ndev->priv_flags |= IFF_UNICAST_FLT;
   739	
   740		if (si->hw_features & ENETC_SI_F_QBV)
   741			priv->active_offloads |= ENETC_F_QBV;
   742	
 > 743		if (si->hw_features & ENETC_SI_F_PSFP && !enetc_psfp_enable(priv)) {
   744			priv->active_offloads |= ENETC_F_QCI;
   745			ndev->features |= NETIF_F_HW_TC;
   746			ndev->hw_features |= NETIF_F_HW_TC;
   747		}
   748	
   749		/* pick up primary MAC address from SI */
   750		enetc_get_primary_mac_addr(&si->hw, ndev->dev_addr);
   751	}
   752	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48949 bytes --]