From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] nvmem: core: use is_bin_visible for permissions
Date: Wed, 25 Mar 2020 08:36:56 +0100 [thread overview]
Message-ID: <20200325073656.GA2985010@kroah.com> (raw)
In-Reply-To: <PSXP216MB04380BBC9B7488DEC47ACB6A80F10@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Tue, Mar 24, 2020 at 11:05:07PM +0000, Nicholas Johnson wrote:
> On Tue, Mar 24, 2020 at 05:16:00PM +0000, Srinivas Kandagatla wrote:
> > By using is_bin_visible callback to set permissions will remove a large list
> > of attribute groups. These group permissions can be dynamically derived in
> > the callback.
> >
> > Suggested-by: Greg KH <gregkh@linuxfoundation.org>
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> > ---
> > drivers/nvmem/nvmem-sysfs.c | 74 +++++++++----------------------------
> > 1 file changed, 18 insertions(+), 56 deletions(-)
> >
> > diff --git a/drivers/nvmem/nvmem-sysfs.c b/drivers/nvmem/nvmem-sysfs.c
> > index 8759c4470012..1ff1801048f6 100644
> > --- a/drivers/nvmem/nvmem-sysfs.c
> > +++ b/drivers/nvmem/nvmem-sysfs.c
> > @@ -103,6 +103,17 @@ static ssize_t bin_attr_nvmem_write(struct file *filp, struct kobject *kobj,
> >
> > return count;
> > }
> > +static umode_t nvmem_bin_attr_is_visible(struct kobject *kobj,
> > + struct bin_attribute *attr, int i)
> > +{
> > + struct device *dev = container_of(kobj, struct device, kobj);
> > + struct nvmem_device *nvmem = to_nvmem_device(dev);
> > +
> > + if (nvmem->root_only)
> > + return nvmem->read_only ? 0400 : 0600;
> > +
> > + return nvmem->read_only ? 0444 : 0644;
> > +}
> Looks like I did a pretty good job as I arrived at a similar result
> independently. Even added root_only to nvmem_device. You beat me to it.
> :)
>
> > const struct attribute_group **nvmem_sysfs_get_groups(
> > struct nvmem_device *nvmem,
> > const struct nvmem_config *config)
> > {
> > - if (config->root_only)
> > - return nvmem->read_only ?
> > - nvmem_ro_root_dev_groups :
> > - nvmem_rw_root_dev_groups;
> > -
> > - return nvmem->read_only ? nvmem_ro_dev_groups : nvmem_rw_dev_groups;
> > + return nvmem_dev_groups;
> > }
> I was wondering if we can export nvmem_dev_group instead of this
> nvmem_sysfs_get_groups() to fetch it.
>
> Also, we need some logic in nvmem_register() to abort if bad combination
> is given (i.e. root_only set but no reg_read), as returning 0 in
> is_bin_visible callback does not abort. I can do that in my patch if you
> want.
Returning 0 will cause the file to not be created at all, which is
probably what you want, right?
thanks,
greg k-h
next prev parent reply other threads:[~2020-03-25 7:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 17:15 [PATCH 0/3] nvmem: use is_bin_visible callback Srinivas Kandagatla
2020-03-24 17:15 ` [PATCH 1/3] nvmem: core: use device_register and device_unregister Srinivas Kandagatla
2020-03-24 17:15 ` [PATCH 2/3] nvmem: core: add root_only member to nvmem device struct Srinivas Kandagatla
2020-03-24 17:16 ` [PATCH 3/3] nvmem: core: use is_bin_visible for permissions Srinivas Kandagatla
2020-03-24 17:46 ` Greg KH
2020-03-25 9:15 ` Srinivas Kandagatla
2020-03-24 23:05 ` Nicholas Johnson
2020-03-25 7:36 ` gregkh [this message]
2020-03-25 9:36 ` Srinivas Kandagatla
2020-03-24 17:58 ` [PATCH 0/3] nvmem: use is_bin_visible callback Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325073656.GA2985010@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).