From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA1CAC54FD0 for ; Wed, 25 Mar 2020 09:15:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE1EB2078D for ; Wed, 25 Mar 2020 09:15:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726998AbgCYJPE (ORCPT ); Wed, 25 Mar 2020 05:15:04 -0400 Received: from mx2.suse.de ([195.135.220.15]:46044 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725903AbgCYJPE (ORCPT ); Wed, 25 Mar 2020 05:15:04 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 950E3ABD1; Wed, 25 Mar 2020 09:15:01 +0000 (UTC) Date: Wed, 25 Mar 2020 10:14:57 +0100 From: Jean Delvare To: Geert Uytterhoeven Cc: Linus Walleij , Bartosz Golaszewski , Jonathan Corbet , Harish Jenny K N , Eugeniu Rosca , Alexander Graf , Peter Maydell , Paolo Bonzini , Phil Reid , Marc Zyngier , Christoffer Dall , Magnus Damm , Rob Herring , Mark Rutland , , , , , , Subject: Re: [PATCH v6 2/8] i2c: i801: Use GPIO_LOOKUP() helper macro Message-ID: <20200325101457.0fff5bb9@endymion> In-Reply-To: <20200324135653.6676-2-geert+renesas@glider.be> References: <20200324135328.5796-1-geert+renesas@glider.be> <20200324135653.6676-1-geert+renesas@glider.be> <20200324135653.6676-2-geert+renesas@glider.be> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 24 Mar 2020 14:56:47 +0100, Geert Uytterhoeven wrote: > i801_add_mux() fills in the GPIO lookup table by manually populating an > array of gpiod_lookup structures. Use the existing GPIO_LOOKUP() helper > macro instead, to relax a dependency on the gpiod_lookup structure's > member names. > > Signed-off-by: Geert Uytterhoeven > Cc: Jean Delvare > Cc: linux-i2c@vger.kernel.org > --- > While this patch is a dependency for "[PATCH v6 4/8] gpiolib: Add > support for GPIO lookup by line name", it can be applied independently. > But an Acked-by would be nice, too. > > Cover letter and full series at > https://lore.kernel.org/r/20200324135328.5796-1-geert+renesas@glider.be/ > > v6: > - New. > --- > drivers/i2c/busses/i2c-i801.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index ca4f096fef749302..8e64a71bea684cc7 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1444,9 +1444,9 @@ static int i801_add_mux(struct i801_priv *priv) > return -ENOMEM; > lookup->dev_id = "i2c-mux-gpio"; > for (i = 0; i < mux_config->n_gpios; i++) { > - lookup->table[i].chip_label = mux_config->gpio_chip; > - lookup->table[i].chip_hwnum = mux_config->gpios[i]; > - lookup->table[i].con_id = "mux"; > + lookup->table[i] = (struct gpiod_lookup) > + GPIO_LOOKUP(mux_config->gpio_chip, > + mux_config->gpios[i], "mux", 0); > } > gpiod_add_lookup_table(lookup); > priv->lookup = lookup; Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support